Coder Social home page Coder Social logo

Comments (6)

okhat avatar okhat commented on August 26, 2024 1

Hey Thibault! Hope you’re well.

I can check but basically we return k, but we compute exact scores for a larger number than k

from colbert.

okhat avatar okhat commented on August 26, 2024 1

This sounds right, but @santhnm2 might be able to confirm too

from colbert.

thibault-formal avatar thibault-formal commented on August 26, 2024

Hey Omar! I hope you are well too!
I see -- so basically

  • in the k=10 scenario, you compute 256/4=64 exact scores
  • in the k=100 scenario, you compute 1024/4=256 exact scores
    etc.

Just checking that I got things correctly, as I have been working on related stuff :)
Thanks

from colbert.

santhnm2 avatar santhnm2 commented on August 26, 2024

Yes this is correct, this function is where we choose the hyperparameters according to k: https://github.com/stanford-futuredata/ColBERT/blob/main/colbert/searcher.py#L88
And here is where the number of exact scores is computed:

pids = pids[torch.topk(approx_scores, k=(config.ndocs // 4)).indices]

from colbert.

thibault-formal avatar thibault-formal commented on August 26, 2024

Perfect, thank you both for the quick answer!

from colbert.

thibault-formal avatar thibault-formal commented on August 26, 2024

Hi again,

I have another (unrelated) question regarding PLAID: did you evaluate the performance on the BEIR benchmark? Could there be a performance drop (OOD) due to the approximation?

EDIT: I saw the Lotte results (apparently no drop) but I wonder if it's also true on BEIR

Thanks

from colbert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.