Coder Social home page Coder Social logo

Comments (14)

jgabry avatar jgabry commented on June 5, 2024

That's a good point. I never thought of that. Do you think a note in the
launch_shinystan function documentation is sufficient?

On Sat, Jul 18, 2015 at 1:26 PM, bgoodri [email protected] wrote:

Many people include the NoScript or similar add-ons that block JavaScript
execution by default. In that case, shinystan launches but does not do much
of anything. In that case, there should be a warning / explanation
somewhere that the user should allow JavaScript to execute from that local
URL.


Reply to this email directly or view it on GitHub
#77.

from shinystan.

bgoodri avatar bgoodri commented on June 5, 2024

Ideally, generate a message in the webbrowser if JavaScript is disabled but
failing that, then warnings all over the place is the next best thing.

On Sat, Jul 18, 2015 at 1:29 PM, Jonah Gabry [email protected]
wrote:

That's a good point. I never thought of that. Do you think a note in the
launch_shinystan function documentation is sufficient?

On Sat, Jul 18, 2015 at 1:26 PM, bgoodri [email protected] wrote:

Many people include the NoScript or similar add-ons that block JavaScript
execution by default. In that case, shinystan launches but does not do
much
of anything. In that case, there should be a warning / explanation
somewhere that the user should allow JavaScript to execute from that
local
URL.


Reply to this email directly or view it on GitHub
#77.


Reply to this email directly or view it on GitHub
#77 (comment).

from shinystan.

bob-carpenter avatar bob-carpenter commented on June 5, 2024

I think people disabling JavaScript should be used to
pretty much nothing working on the web.

  • Bob

On Jul 18, 2015, at 10:26 AM, bgoodri [email protected] wrote:

Many people include the NoScript or similar add-ons that block JavaScript execution by default. In that case, shinystan launches but does not do much of anything. In that case, there should be a warning / explanation somewhere that the user should allow JavaScript to execute from that local URL.


Reply to this email directly or view it on GitHub.

from shinystan.

bgoodri avatar bgoodri commented on June 5, 2024

They might be using a foreign computer and / or expecting it to work for
local URLs but not have the shinystan port whitelisted.

On Sat, Jul 18, 2015 at 1:52 PM, Bob Carpenter [email protected]
wrote:

I think people disabling JavaScript should be used to
pretty much nothing working on the web.

  • Bob

On Jul 18, 2015, at 10:26 AM, bgoodri [email protected] wrote:

Many people include the NoScript or similar add-ons that block
JavaScript execution by default. In that case, shinystan launches but does
not do much of anything. In that case, there should be a warning /
explanation somewhere that the user should allow JavaScript to execute from
that local URL.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#77 (comment).

from shinystan.

andrewgelman avatar andrewgelman commented on June 5, 2024

Just by the way—I’m pretty sure this was not the bug that caused Shinystan to fail for me.

P.S. I hate camelcase. Shinystan, ShinyStan, shinyStan, I can never remember which it is. It’s weird that the package is shinyStan but the R function is launch_shinystan without the capital S.

On Jul 18, 2015, at 1:52 PM, Bob Carpenter [email protected] wrote:

I think people disabling JavaScript should be used to
pretty much nothing working on the web.

  • Bob

On Jul 18, 2015, at 10:26 AM, bgoodri [email protected] wrote:

Many people include the NoScript or similar add-ons that block JavaScript execution by default. In that case, shinystan launches but does not do much of anything. In that case, there should be a warning / explanation somewhere that the user should allow JavaScript to execute from that local URL.

from shinystan.

jgabry avatar jgabry commented on June 5, 2024

I know. I'm regretting it. Is it too late to just change the package name to shinystan?

from shinystan.

jgabry avatar jgabry commented on June 5, 2024

@bgoodri Whenever you have a chance can you try reinstalling from the shinystan2 branch and opening in a browser with disabled javascript? It should now display a big warning in orange. Seems to work, but I'd like someone else to try it too before I close the issue. Thanks.

from shinystan.

bgoodri avatar bgoodri commented on June 5, 2024

I get


> devtools::install_github("stan-dev/shinystan", ref = "shinystan2")Downloading github repo stan-dev/shinystan@shinystan2Installing shinystanSkipping 1 packages ahead of CRAN: DT'/usr/lib/R/bin/R' --no-site-file --no-environ --no-save --no-restore CMD INSTALL  \
  '/tmp/Rtmp8Tr9gm/devtools4e5b25416ac2/stan-dev-shinystan-0c73594'  \
  --library='/usr/local/lib/R/site-library' --install-tests *
installing *source* package ‘shinystan’ ...** R** data*** moving
datasets to lazyload DB** inst** tests** preparing package for lazy
loadingError in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()),
versionCheck = vI[[j]]) :
  namespace ‘reshape2’ 1.4 is already loaded, but >= 1.4.1 is
requiredERROR: lazy loading failed for package ‘shinystan’* removing
‘/usr/local/lib/R/site-library/shinystan’Error: Command failed (1)```

even though I have reshape2 1.4.1.


Ben


On Fri, Aug 7, 2015 at 6:28 PM, Jonah Gabry <[email protected]>
wrote:

> @bgoodri <https://github.com/bgoodri> Whenever you have a chance can you
> try reinstalling from the shinystan2 branch and opening in a browser with
> disabled javascript? It should now display a big warning in orange. Seems
> to work, but I'd like someone else to try it too before I close the issue.
> Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stan-dev/shinystan/issues/77#issuecomment-128847918>.
>

from shinystan.

jgabry avatar jgabry commented on June 5, 2024

Weird. Well, I removed the version requirement for reshape2 from the
description file. Does that get rid of the error? I just tried
install_github myself and it seems to work fine.

On Fri, Aug 7, 2015 at 9:30 PM, bgoodri [email protected] wrote:

I get


> devtools::install_github("stan-dev/shinystan", ref =
"shinystan2")Downloading github repo stan-dev/shinystan@shinystan2Installing
shinystanSkipping 1 packages ahead of CRAN: DT'/usr/lib/R/bin/R'
--no-site-file --no-environ --no-save --no-restore CMD INSTALL \
'/tmp/Rtmp8Tr9gm/devtools4e5b25416ac2/stan-dev-shinystan-0c73594' \
--library='/usr/local/lib/R/site-library' --install-tests *
installing *source* package ‘shinystan’ ...** R** data*** moving
datasets to lazyload DB** inst** tests** preparing package for lazy
loadingError in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()),
versionCheck = vI[[j]]) :
namespace ‘reshape2’ 1.4 is already loaded, but >= 1.4.1 is
requiredERROR: lazy loading failed for package ‘shinystan’* removing
‘/usr/local/lib/R/site-library/shinystan’Error: Command failed (1)```

even though I have reshape2 1.4.1.


Ben


On Fri, Aug 7, 2015 at 6:28 PM, Jonah Gabry <[email protected]>
wrote:

> @bgoodri <https://github.com/bgoodri> Whenever you have a chance can you
> try reinstalling from the shinystan2 branch and opening in a browser with
> disabled javascript? It should now display a big warning in orange. Seems
> to work, but I'd like someone else to try it too before I close the
issue.
> Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stan-dev/shinystan/issues/77#issuecomment-128847918
>.

>

—
Reply to this email directly or view it on GitHub
<https://github.com/stan-dev/shinystan/issues/77#issuecomment-128879458>.

from shinystan.

bgoodri avatar bgoodri commented on June 5, 2024

Yes it seems fine now.

On Fri, Aug 7, 2015 at 10:19 PM, Jonah Gabry [email protected]
wrote:

Weird. Well, I removed the version requirement for reshape2 from the
description file. Does that get rid of the error? I just tried
install_github myself and it seems to work fine.

On Fri, Aug 7, 2015 at 9:30 PM, bgoodri [email protected] wrote:

I get


> devtools::install_github("stan-dev/shinystan", ref =
"shinystan2")Downloading github repo
stan-dev/shinystan@shinystan2Installing
shinystanSkipping 1 packages ahead of CRAN: DT'/usr/lib/R/bin/R'
--no-site-file --no-environ --no-save --no-restore CMD INSTALL \
'/tmp/Rtmp8Tr9gm/devtools4e5b25416ac2/stan-dev-shinystan-0c73594' \
--library='/usr/local/lib/R/site-library' --install-tests *
installing *source* package ‘shinystan’ ...** R** data*** moving
datasets to lazyload DB** inst** tests** preparing package for lazy
loadingError in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()),
versionCheck = vI[[j]]) :
namespace ‘reshape2’ 1.4 is already loaded, but >= 1.4.1 is
requiredERROR: lazy loading failed for package ‘shinystan’* removing
‘/usr/local/lib/R/site-library/shinystan’Error: Command failed (1)```

even though I have reshape2 1.4.1.


Ben


On Fri, Aug 7, 2015 at 6:28 PM, Jonah Gabry <[email protected]>
wrote:

> @bgoodri <https://github.com/bgoodri> Whenever you have a chance can
you
> try reinstalling from the shinystan2 branch and opening in a browser
with
> disabled javascript? It should now display a big warning in orange.
Seems
> to work, but I'd like someone else to try it too before I close the
issue.
> Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <
https://github.com/stan-dev/shinystan/issues/77#issuecomment-128847918
>.

>

—
Reply to this email directly or view it on GitHub
<https://github.com/stan-dev/shinystan/issues/77#issuecomment-128879458
.



Reply to this email directly or view it on GitHub
#77 (comment).

from shinystan.

jgabry avatar jgabry commented on June 5, 2024

I assume the javascript warning worked too?

On Fri, Aug 7, 2015 at 10:30 PM, bgoodri [email protected] wrote:

Yes it seems fine now.

On Fri, Aug 7, 2015 at 10:19 PM, Jonah Gabry [email protected]

wrote:

Weird. Well, I removed the version requirement for reshape2 from the
description file. Does that get rid of the error? I just tried
install_github myself and it seems to work fine.

On Fri, Aug 7, 2015 at 9:30 PM, bgoodri [email protected]
wrote:

I get


> devtools::install_github("stan-dev/shinystan", ref =
"shinystan2")Downloading github repo
stan-dev/shinystan@shinystan2Installing
shinystanSkipping 1 packages ahead of CRAN: DT'/usr/lib/R/bin/R'
--no-site-file --no-environ --no-save --no-restore CMD INSTALL \
'/tmp/Rtmp8Tr9gm/devtools4e5b25416ac2/stan-dev-shinystan-0c73594' \
--library='/usr/local/lib/R/site-library' --install-tests *
installing *source* package ‘shinystan’ ...** R** data*** moving
datasets to lazyload DB** inst** tests** preparing package for lazy
loadingError in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()),
versionCheck = vI[[j]]) :
namespace ‘reshape2’ 1.4 is already loaded, but >= 1.4.1 is
requiredERROR: lazy loading failed for package ‘shinystan’* removing
‘/usr/local/lib/R/site-library/shinystan’Error: Command failed (1)```

even though I have reshape2 1.4.1.


Ben


On Fri, Aug 7, 2015 at 6:28 PM, Jonah Gabry <[email protected]>
wrote:

> @bgoodri <https://github.com/bgoodri> Whenever you have a chance can
you
> try reinstalling from the shinystan2 branch and opening in a browser
with
> disabled javascript? It should now display a big warning in orange.
Seems
> to work, but I'd like someone else to try it too before I close the
issue.
> Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <
https://github.com/stan-dev/shinystan/issues/77#issuecomment-128847918
>.

>

—
Reply to this email directly or view it on GitHub
<
https://github.com/stan-dev/shinystan/issues/77#issuecomment-128879458
.



Reply to this email directly or view it on GitHub
<#77 (comment)
.


Reply to this email directly or view it on GitHub
#77 (comment).

from shinystan.

bgoodri avatar bgoodri commented on June 5, 2024

Well, the usual message appeared at the top when it didn't work, which is
what most websites do.

On Fri, Aug 7, 2015 at 10:40 PM, Jonah Gabry [email protected]
wrote:

I assume the javascript warning worked too?

On Fri, Aug 7, 2015 at 10:30 PM, bgoodri [email protected] wrote:

Yes it seems fine now.

On Fri, Aug 7, 2015 at 10:19 PM, Jonah Gabry [email protected]

wrote:

Weird. Well, I removed the version requirement for reshape2 from the
description file. Does that get rid of the error? I just tried
install_github myself and it seems to work fine.

On Fri, Aug 7, 2015 at 9:30 PM, bgoodri [email protected]
wrote:

I get


> devtools::install_github("stan-dev/shinystan", ref =
"shinystan2")Downloading github repo
stan-dev/shinystan@shinystan2Installing
shinystanSkipping 1 packages ahead of CRAN: DT'/usr/lib/R/bin/R'
--no-site-file --no-environ --no-save --no-restore CMD INSTALL \
'/tmp/Rtmp8Tr9gm/devtools4e5b25416ac2/stan-dev-shinystan-0c73594' \
--library='/usr/local/lib/R/site-library' --install-tests *
installing *source* package ‘shinystan’ ...** R** data*** moving
datasets to lazyload DB** inst** tests** preparing package for lazy
loadingError in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()),
versionCheck = vI[[j]]) :
namespace ‘reshape2’ 1.4 is already loaded, but >= 1.4.1 is
requiredERROR: lazy loading failed for package ‘shinystan’* removing
‘/usr/local/lib/R/site-library/shinystan’Error: Command failed (1)```

even though I have reshape2 1.4.1.


Ben


On Fri, Aug 7, 2015 at 6:28 PM, Jonah Gabry <
[email protected]>
wrote:

> @bgoodri <https://github.com/bgoodri> Whenever you have a chance
can
you
> try reinstalling from the shinystan2 branch and opening in a
browser
with
> disabled javascript? It should now display a big warning in orange.
Seems
> to work, but I'd like someone else to try it too before I close the
issue.
> Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <
https://github.com/stan-dev/shinystan/issues/77#issuecomment-128847918
>.

>

—
Reply to this email directly or view it on GitHub
<
https://github.com/stan-dev/shinystan/issues/77#issuecomment-128879458
.



Reply to this email directly or view it on GitHub
<
#77 (comment)
.


Reply to this email directly or view it on GitHub
<#77 (comment)
.


Reply to this email directly or view it on GitHub
#77 (comment).

from shinystan.

jgabry avatar jgabry commented on June 5, 2024

Ok can I close this issue or were you think we need more JavaScript
warnings?

On Friday, August 7, 2015, bgoodri [email protected] wrote:

Well, the usual message appeared at the top when it didn't work, which is
what most websites do.

On Fri, Aug 7, 2015 at 10:40 PM, Jonah Gabry <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

I assume the javascript warning worked too?

On Fri, Aug 7, 2015 at 10:30 PM, bgoodri <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

Yes it seems fine now.

On Fri, Aug 7, 2015 at 10:19 PM, Jonah Gabry <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>

wrote:

Weird. Well, I removed the version requirement for reshape2 from the
description file. Does that get rid of the error? I just tried
install_github myself and it seems to work fine.

On Fri, Aug 7, 2015 at 9:30 PM, bgoodri <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

I get


> devtools::install_github("stan-dev/shinystan", ref =
"shinystan2")Downloading github repo
stan-dev/shinystan@shinystan2Installing
shinystanSkipping 1 packages ahead of CRAN: DT'/usr/lib/R/bin/R'
--no-site-file --no-environ --no-save --no-restore CMD INSTALL \
'/tmp/Rtmp8Tr9gm/devtools4e5b25416ac2/stan-dev-shinystan-0c73594' \
--library='/usr/local/lib/R/site-library' --install-tests *
installing *source* package ‘shinystan’ ...** R** data*** moving
datasets to lazyload DB** inst** tests** preparing package for lazy
loadingError in loadNamespace(j <- i[[1L]], c(lib.loc,
.libPaths()),
versionCheck = vI[[j]]) :
namespace ‘reshape2’ 1.4 is already loaded, but >= 1.4.1 is
requiredERROR: lazy loading failed for package ‘shinystan’*
removing
‘/usr/local/lib/R/site-library/shinystan’Error: Command failed
(1)```

even though I have reshape2 1.4.1.


Ben


On Fri, Aug 7, 2015 at 6:28 PM, Jonah Gabry <
[email protected]
<javascript:_e(%7B%7D,'cvml','[email protected]');>>
wrote:

> @bgoodri <https://github.com/bgoodri> Whenever you have a chance
can
you
> try reinstalling from the shinystan2 branch and opening in a
browser
with
> disabled javascript? It should now display a big warning in
orange.
Seems
> to work, but I'd like someone else to try it too before I close
the
issue.
> Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <

#77 (comment)

.


Reply to this email directly or view it on GitHub
<
#77 (comment)
.


Reply to this email directly or view it on GitHub
<
#77 (comment)
.


Reply to this email directly or view it on GitHub
<
#77 (comment)
.


Reply to this email directly or view it on GitHub
<#77 (comment)
.


Reply to this email directly or view it on GitHub
#77 (comment).

from shinystan.

bgoodri avatar bgoodri commented on June 5, 2024

Close it.

On Fri, Aug 7, 2015 at 10:49 PM, Jonah Gabry [email protected]
wrote:

Ok can I close this issue or were you think we need more JavaScript
warnings?

On Friday, August 7, 2015, bgoodri [email protected] wrote:

Well, the usual message appeared at the top when it didn't work, which is
what most websites do.

On Fri, Aug 7, 2015 at 10:40 PM, Jonah Gabry <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

I assume the javascript warning worked too?

On Fri, Aug 7, 2015 at 10:30 PM, bgoodri <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

Yes it seems fine now.

On Fri, Aug 7, 2015 at 10:19 PM, Jonah Gabry <
[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>

wrote:

Weird. Well, I removed the version requirement for reshape2 from
the
description file. Does that get rid of the error? I just tried
install_github myself and it seems to work fine.

On Fri, Aug 7, 2015 at 9:30 PM, bgoodri <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

I get


> devtools::install_github("stan-dev/shinystan", ref =
"shinystan2")Downloading github repo
stan-dev/shinystan@shinystan2Installing
shinystanSkipping 1 packages ahead of CRAN: DT'/usr/lib/R/bin/R'
--no-site-file --no-environ --no-save --no-restore CMD INSTALL \

'/tmp/Rtmp8Tr9gm/devtools4e5b25416ac2/stan-dev-shinystan-0c73594' \
--library='/usr/local/lib/R/site-library' --install-tests *
installing *source* package ‘shinystan’ ...** R** data*** moving
datasets to lazyload DB** inst** tests** preparing package for
lazy
loadingError in loadNamespace(j <- i[[1L]], c(lib.loc,
.libPaths()),
versionCheck = vI[[j]]) :
namespace ‘reshape2’ 1.4 is already loaded, but >= 1.4.1 is
requiredERROR: lazy loading failed for package ‘shinystan’*
removing
‘/usr/local/lib/R/site-library/shinystan’Error: Command failed
(1)```

even though I have reshape2 1.4.1.


Ben


On Fri, Aug 7, 2015 at 6:28 PM, Jonah Gabry <
[email protected]
<javascript:_e(%7B%7D,'cvml','[email protected]');>>

wrote:

> @bgoodri <https://github.com/bgoodri> Whenever you have a
chance
can
you
> try reinstalling from the shinystan2 branch and opening in a
browser
with
> disabled javascript? It should now display a big warning in
orange.
Seems
> to work, but I'd like someone else to try it too before I close
the
issue.
> Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <

#77 (comment)

.


Reply to this email directly or view it on GitHub
<

#77 (comment)

.


Reply to this email directly or view it on GitHub
<
#77 (comment)
.


Reply to this email directly or view it on GitHub
<
#77 (comment)
.


Reply to this email directly or view it on GitHub
<
#77 (comment)
.


Reply to this email directly or view it on GitHub
<#77 (comment)
.


Reply to this email directly or view it on GitHub
#77 (comment).

from shinystan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.