Comments (4)
How about, since people apparently use this endpoint, we instead fix /v2/fees/transfer
to do what it's supposed to do?
from stacks-core.
How about, since people apparently use this endpoint, we instead fix
/v2/fees/transfer
to do what it's supposed to do?
From being on the receiving end of a lot of questions / tech support requests around this, I'll just say one endpoint is better / less confusing than two.
from stacks-core.
If you're seeing people query this endpoint, then I think it's safe to assume that the questions / tech support requests aren't going to go away if we just disable it. They'll just ask why it broke.
The endpoint is indeed broken insofar as it returns incorrect data. However, it's straightforward to make it return correct data, since it can rely on the same machinery that /v2/fees/transaction
uses. Also, it's a lot less clunky than /v2/fees/transaction
if you're just sending a token-transfer -- it'll give you a scalar fee in response to a body-less GET request, as opposed to requiring you to serialize and POST your transaction to the node and then parse a JSON response.
I'll go ahead and fix it.
from stacks-core.
Fixed: #4754
from stacks-core.
Related Issues (20)
- [Primary TESTNET] PeerNotConnected HOT 1
- [testing] Testing scenarios for miner/signer behaviour
- [Testing] multiple signers and miners each with their own stacks node HOT 2
- [testing] Force a stacks fork with two competing miners.
- [testing] signer set handoff test
- [testing] Test a bitcoin fork and ensure that the miner/signer flow recovers HOT 1
- Set up a stable Multi-miner Testnet for Nakamoto 3.0
- Contracts and contract-calls which invoke Clarity 3 features are regularly published and executed with correct values on a multi-miner testnet
- Successful mock signing on Testnets
- Successful mock signing on Mainnet
- Mock miner 2.5 replay
- Verify that the 1-block stop during the 2.5 to 3.0 transition that occurs in our integration tests is in fact an integration test bug, and is not the nodeβs true behavior.
- Full chainstate replay with binary. HOT 3
- Consider creating a separate Dockerfile for the Stacks Signer HOT 1
- Ensure bitcoin ops always include a change address
- Signer: Mark sortition as invalid if timely block proposal not received
- Support reuse of an existing VRF on restart in nakamoto node
- Signers should broadcast block themselves when signing threshold is crossed
- Move Most Relevant Signer Logs to be displayed on Info instead of Debug
- Add ability to set signer version via env var at build time HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stacks-core.