Coder Social home page Coder Social logo

Avoid extraneous CI runs about stacks-blockchain HOT 6 OPEN

obycode avatar obycode commented on August 16, 2024
Avoid extraneous CI runs

from stacks-blockchain.

Comments (6)

wileyj avatar wileyj commented on August 16, 2024 1

actually, i think i have my answer - it's possible now, but will have to come in a future PR. for now i'll simply remove the ignored paths trigger:

    paths-ignore:
      - "**.md"
      - "**.yml"

from stacks-blockchain.

wileyj avatar wileyj commented on August 16, 2024

i'm kind of thinking here that we should only trigger on

  • synchronize
  • ready_for_review

i'm going to try a few options here, then PR against next

from stacks-blockchain.

obycode avatar obycode commented on August 16, 2024

I think I would lean toward "opened" and "synchronize". Removing "opened" and keeping "ready_for_review" would not allow us to check the test status before asking for reviews, and that seems like a good practice. Unless we're really concerned about using too much runner time on "not ready" PRs, then I could understand that change.

from stacks-blockchain.

wileyj avatar wileyj commented on August 16, 2024

I think I would lean toward "opened" and "synchronize". Removing "opened" and keeping "ready_for_review" would not allow us to check the test status before asking for reviews, and that seems like a good practice. Unless we're really concerned about using too much runner time on "not ready" PRs, then I could understand that change.

yea, i see where you're coming from and that's a good point. no reason to review if the expected tests are failing

from stacks-blockchain.

wileyj avatar wileyj commented on August 16, 2024

@obycode i found an interesting edge case that might cause some problems without further changes.

consider the case where a branch is PR'ed where the only change is to CHANGELOG.md or some other non-code file (currently configured to ignore md and yml files).
In this scenario, CI will never run - but the status checks are still enabled which would require either a small "code" change (like an extra comment/line in a file), or an override to merge a PR (which i woild prefer avoiding).

i'm not sure if there's a way to disable status checks based on what is changed in the PR, leaving the only other option being that we trigger workflows on any PR change, markdown files included.

any thoughts on this?

from stacks-blockchain.

wileyj avatar wileyj commented on August 16, 2024

next: #4764
develop: #4765
master: #4766

from stacks-blockchain.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.