[BUG] Linter reporting a low number of replicas for deployments with PDB and HPA minReplicas about kube-linter

[janisz]

@gerodriguez-fan Thank you for reporting this. Could you please add an example yaml (you can use our test yaml`s as a base) just to make sure we are talking about same thing.

From the description the problem could be the replicas we are using. So we are comparing replicas not minReplicas in PDB.

kube-linter/pkg/templates/pdbminavailable/template.go

Lines 105 to 112 in e2c0cdb

	replicas, _ := extract.Replicas(dl)
	if isPercent {
	// Calulate the actual value of the MinAvailable with respect to the Replica count if a percentage is set
	pdbMinAvailable = int(math.Ceil(float64(replicas) * (float64(value) / float64(100))))
	}
	if replicas <= int32(pdbMinAvailable) {
	results = append(results, diagnostic.Diagnostic{
	Message: fmt.Sprintf("The current number of replicas for deployment %s is equal to or lower than the minimum number of replicas specified by its PDB.", dl.GetName()),

@gerodriguez-fan Would you like to work on this issue?

[jpedrobf]

I'm having a similar issue even when I use a percentage value on minAvailable. My deployment spec doesn't have .spec.replicas declared as I use the HPA min/max parameters and any value I put on the pdb ends up with an error.

my pdb spec:

spec:
  minAvailable: 75%
  selector:
    matchLabels:
      app: example

my deployment spec (to show it doesn't have replicas):

spec:
  revisionHistoryLimit: 3
  progressDeadlineSeconds: 600
  strategy:
    rollingUpdate:
      maxSurge: 10%
      maxUnavailable: 0
    type: RollingUpdate
  selector:
    matchLabels:
      app: example
  template: [...]

---

What I've noticed:

• This started to happen when I updated the pdb apiVersion from policy/v1beta1 to policy/v1.
• If I force a .spec.replicas on my deployment, the minAvailable percentage needs to result in at least 1 available disruption (which makes sense). In this example, the minimal replicas to avoid the error is 4 (75% results in 3 disruptions, leaving 1 available disruption); The thing is, my hpa minReplicas is 60.

I'm using KubeLinter 0.6.4 both on Mac (local) and Linux (pipeline)

[gerodriguez-fan]

@gerodriguez-fan Thank you for reporting this. Could you please add an example yaml (you can use our test yaml`s as a base) just to make sure we are talking about same thing.

From the description the problem could be the replicas we are using. So we are comparing replicas not minReplicas in PDB.

kube-linter/pkg/templates/pdbminavailable/template.go

Lines 105 to 112 in e2c0cdb

	replicas, _ := extract.Replicas(dl)
	if isPercent {
	// Calulate the actual value of the MinAvailable with respect to the Replica count if a percentage is set
	pdbMinAvailable = int(math.Ceil(float64(replicas) * (float64(value) / float64(100))))
	}
	if replicas <= int32(pdbMinAvailable) {
	results = append(results, diagnostic.Diagnostic{
	Message: fmt.Sprintf("The current number of replicas for deployment %s is equal to or lower than the minimum number of replicas specified by its PDB.", dl.GetName()),

@gerodriguez-fan Would you like to work on this issue?

I can give it a try,

[janisz]

Closed with #688