Add HTTPRepository about cumulusrdf

[GoogleCodeExporter]

See also: org.openrdf.repository.http.HTTPRepository.

- Andreas

Original comment by andreas.josef.wagner on 22 Jan 2014 at 9:07

[GoogleCodeExporter]

* Assign to Yongtao.
* See attached notes.

Original comment by andreas.josef.wagner on 12 Mar 2014 at 2:54

• Changed state: Started

Attachments:

• notes_httprepository.txt

[GoogleCodeExporter]

Original comment by [email protected] on 9 Apr 2014 at 3:28

• Changed state: Fixed

[GoogleCodeExporter]

Hi, it seems you are not on devlist...there is Jenkins [1] which is 
continuously failing the build after your changes. 

http://dev.aifb.kit.edu/jenkins/job/CumulusRDF-Milestone-v1.1/

AG

Original comment by [email protected] on 9 Apr 2014 at 3:39

[GoogleCodeExporter]

Hi,

please update the pom file in cumulusrdf-web-module and cumulus. I checked in 
these files later yesterday after first commitment. 

Original comment by [email protected] on 9 Apr 2014 at 3:49

[GoogleCodeExporter]

Hi, 
I didn't get the point: who should update the pom? Jenkins is doing a synch to 
the last revision before running the build

Yes, I saw you changed these files...but the HTTPRepositoryTest is failing.

Original comment by [email protected] on 9 Apr 2014 at 4:11

[GoogleCodeExporter]

Hi,

In the previous emails list, people showed the errors that are due to package 
missing. So I said that is because the pom is not updated. But if Jenkins is 
working on the last revision, that would be not the problem.

I checked the errors again, that is because in the test, the tomcat is using 
8080 port, which however have already been used by the server and resulted in 
the test failed. So now I change to the port 9999 instead and hope the problem 
can be resolved.

Best,
Yongtao

Original comment by [email protected] on 9 Apr 2014 at 4:36

[GoogleCodeExporter]

Hi,

I see the build fails again because the test requires a symlink that is not 
created on the server.

The tomcat embedded in the test requires a symlink named "webapps" in the 
cumulusrdf-web-module dir that points to the cumulusrdf-web-module itself. 
Could anybody helps to do that? because the symlink creation is 
platform-depneded, so I cannot create it in the code. I'm afraid we should 
create it manually.

Best,
Yongtao

Original comment by [email protected] on 9 Apr 2014 at 4:59

[GoogleCodeExporter]

I will then clean the code via checkstyle plugin. 

Original comment by [email protected] on 11 Apr 2014 at 3:18

• Changed state: Accepted

[GoogleCodeExporter]

Also, as discussed:

* please fix the test - do it via object mocking (Mockito framework)
* please add the comments to the Sesame sources that you copied
* please fix the code formatting

Original comment by andreas.josef.wagner on 11 Apr 2014 at 3:29

[GoogleCodeExporter]

* Remove copied Sesame classes from project
* Do we need:

<dependency>
<groupId>org.openrdf.sesame</groupId>
<artifactId>sesame-http-server-spring</artifactId>
<version>2.7.10</version>
</dependency>

- Andreas 

Original comment by andreas.josef.wagner on 12 Apr 2014 at 4:12

[GoogleCodeExporter]

1. what do you mean by removing the sesame class? sesame has already implement 
the http protocol for the use of HttpRepositpry. I think we can just reuse it. 
however, because it is not possible do direct use it, i copy and modified them. 
i added the comment about reuse the sesame`s classes, though not uplode it yet. 
So do you think we should remove the sesame implementation, and recode of the 
very similar code again?

2. the spring is used only for write the responses to the client, rather than 
the purpose for the framework. it is also for the consideration of reuse 
current codes. and sure we can remove it, and again to write the very similar 
code of our own.

Original comment by [email protected] on 12 Apr 2014 at 4:37

[GoogleCodeExporter]

1. okay - in this case please add the license comments. this is crucial.

2. can you give a pointer which method/classes need this?

Thanks :)
Andreas

Original comment by andreas.josef.wagner on 12 Apr 2014 at 4:42

[GoogleCodeExporter]

1. yes, as we have discussed on Friday, we keep it and add comments about the 
licenses. I think it would be fine. I am sorry that I forgot to add the 
comments in last commission.

2. Sesame extended some spring`s ModleAndView class to retrieve the 
content(e.g. statements ), and format the content according to the sesame 
HTTPProtocol. In the ModelAndView classes, it directly use HttpServletResponse 
to write the content back to the client. so the use of ModelAndView class has 
nothing to do with the framework.

Original comment by [email protected] on 12 Apr 2014 at 5:10

[GoogleCodeExporter]

I would make it more clear. All the handler classes in the 
edu.kit.aifb.cumulus.webapp.endpoint package use the classes that extended 
spring ModelAndView, to write the content to the client. So the use of spring 
here is not for and related to the framework purpose, but for the consideration 
of reusing some of spring`s classes.

Original comment by [email protected] on 12 Apr 2014 at 7:39

[GoogleCodeExporter]

Original comment by andreas.josef.wagner on 13 May 2014 at 6:34

• Changed state: Fixed