Generate non-public pool access method about entitas

[sschmid]

True. Atm it's intended, because this code is being generated and we can save a method call. If we start using it in more places, we can extract it to a method.

[npruehs]

Yeah, I had to copy it for my own implementation of IComponentCodeGenerator. Not a big deal, but other people might easily miss the pooling part by just calling the component constructor instead. Your decision :)

[sschmid]

In general extracting such a method would be nice. Not sure if it makes sense in this case. It's in a generated extension a should not be used from a different generated extension. Offering a generic method componentPool.GetComponent<Position>() would work but since it's in a generated file I'd rather go for the better performance by writing new PositionComponent()

[sschmid]

Hi, a quick follow-up:
Just added entity.CreateComponent() which does all the pooling logic now. It's also used by the code generator now.
e641cf1

public Entity AddPerson(int newAge, string newName) {
    var component = CreateComponent<PersonComponent>(ComponentIds.Person);
    component.age = newAge;
    component.name = newName;
    return AddComponent(ComponentIds.Person, component);
}

public Entity ReplacePerson(int newAge, string newName) {
    var component = CreateComponent<PersonComponent>(ComponentIds.Person);
    component.age = newAge;
    component.name = newName;
    ReplaceComponent(ComponentIds.Person, component);
    return this;
}

[npruehs]

Excellent :)