Coder Social home page Coder Social logo

Comments (13)

ssborbis avatar ssborbis commented on August 15, 2024

First: images that opens new pages are treated like links

Do you have an example?

from contextsearch-web-ext.

ssborbis avatar ssborbis commented on August 15, 2024

First: images that opens new pages are treated like links

Oh wait, do you mean images that are encompassed by a link? Ok, that one is known. Let me see if I have a workaround for that.

from contextsearch-web-ext.

Bhaalspawn avatar Bhaalspawn commented on August 15, 2024

https://www.gazzetta.it/
click on the bigger image (now it's something about Gosens)

from contextsearch-web-ext.

ssborbis avatar ssborbis commented on August 15, 2024

The default is to use the image URL over a link URL. Not sure why you're seeing differently. Could you post your config here?

from contextsearch-web-ext.

ssborbis avatar ssborbis commented on August 15, 2024

I just checked that site with my config and the default config. Both use the image URL

from contextsearch-web-ext.

Bhaalspawn avatar Bhaalspawn commented on August 15, 2024

ContextSearchOptions_2023-06-17_000324.zip

from contextsearch-web-ext.

ssborbis avatar ssborbis commented on August 15, 2024

I think it's because you don't have images enabled in the quick menu settings

image

from contextsearch-web-ext.

Bhaalspawn avatar Bhaalspawn commented on August 15, 2024

no because i don't want the quick menu to be active on images and in fact it doesn't appear when i click on images like the ones in amazon (images that don't open new tabs links)
since "link" has its own setting i'm sayiong that all images should be treated in the same way even the ones with links

from contextsearch-web-ext.

ssborbis avatar ssborbis commented on August 15, 2024

Try disabling quickMenuPreventPageClicks

I'll need to look into why exactly this happens, but that seems to be the issue.

from contextsearch-web-ext.

Bhaalspawn avatar Bhaalspawn commented on August 15, 2024

i tried but it didn't solve the problem

from contextsearch-web-ext.

ssborbis avatar ssborbis commented on August 15, 2024

Hmm... ok, just so we're on the same page.

Using your config, as sent, I get this when double-clicking:

before

After disabling quickMenuPreventPageClicks, I get this:

after

Are you seeing something different?

from contextsearch-web-ext.

Bhaalspawn avatar Bhaalspawn commented on August 15, 2024

oh ok so the double click to open image menu is working but since i didn't enable quick menu for images i was expecting i didn't need to double click but just standard click
i thought the fix was for this

from contextsearch-web-ext.

ssborbis avatar ssborbis commented on August 15, 2024

Ah. No, the code used to move the context menu to a double-click stays in place regardless of whether the menu is enabled on a particular type of element or not. That may be something worth looking into, however. Not sure which would be more confusing for the end user; staying consistent over all elements, or switching on / off. Something to think about...

from contextsearch-web-ext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.