Comments (24)
Good idea. I have some code ready to go for the next release. It uses CSS so it may not work on every website, but it's working everywhere I've tested so far. I'll post here again with the option name when I drop the next release.
from contextsearch-web-ext.
1.46.6 going up now
Let me know if the fix worked
from contextsearch-web-ext.
Only a minor thing: With a click on the page-scrollbar the Toolbar-Menu closes, but the page still moves. ... Whereas with the QM the menu stays open and the page also moves. ... Thinking about this ... if possible, I would prefer both menus to close (with a click on the scrollbar) and the page NOT to move
If it's possible, I'll set it up.
from contextsearch-web-ext.
new advanced option searchBarCloseAfterNewTab
added to the master branch if you want to sideload. If you need a signed beta, I'll get one for testing.
from contextsearch-web-ext.
Give this a shot. I need to tidy up a few things and do some testing, but this is more or less the next release
from contextsearch-web-ext.
1.46.8 going live now
from contextsearch-web-ext.
No prob. Re-open this issue if you have any problems
from contextsearch-web-ext.
Ah, wonderful! ... Glad you like it! :-)
from contextsearch-web-ext.
Ah, thank you very much Ssborbis!
It works beautifully. :-)
Only a minor thing: With a click on the page-scrollbar the Toolbar-Menu closes, but the page still moves. ... Whereas with the QM the menu stays open and the page also moves. ... Thinking about this ... if possible, I would prefer both menus to close (with a click on the scrollbar) and the page NOT to move. ... What do you think? ... But again, this is only a minor thing!
Hey ... I wish you a nice weekend! ;-)
from contextsearch-web-ext.
PS: I love ContextSearch! :-)
from contextsearch-web-ext.
Thank you Ssborbis! ... You are the best! :-)
BTW, this is also the way my Bookmark-Toolbar-Button behaves with such a click. The opened bookmark-list closes and the page does not move. ... Makes the most sense to me this way. ... Gives one the complete freedom to click where ever one wants (to close the thing and move on).
from contextsearch-web-ext.
Looks like some issues are popping up #631
I've added this feature as an option in 1.46.7 and will continue testing.
from contextsearch-web-ext.
Ah, dammit! Yes, I can confirm the problems from the bug-report.
In my case they occur, when I leave the tab (with an open Toolbar-Menu) manually by clicking on another tab and also with ContexMenu opening the search-results in another tab for me.
from contextsearch-web-ext.
beta to test here if you're interested ( FF )
from contextsearch-web-ext.
Is the "Bookmark-Toolbar-Button" an addon or are you referring to the built-in button on the browser?
from contextsearch-web-ext.
Is the "Bookmark-Toolbar-Button" an addon or are you referring to the built-in button on the browser?
It is the built-in button. But I still use an old outdated FF ... so it might be different with a current one.
beta to test here if you're interested ( FF )
Ah, great! The bug is gone! :-)
...
One minor thing that I noticed while playing around with this:
Going manually to the opened search-tab closes the Toolbar-menu.
But going automatically to the new search-tab (with defined mouse-click) the Toolbar-menu stays open during the tab-switch and also in the new tab. ... But there the links are not disabled and one risks clicking them.
Actually, I'm not sure, what to prefer here. I mean, if the menu should even stay open over in the new tab? I don't know!? .... I definitely like the QM to stay open in the old tab (after the search(es)). But the toolbar-menu kind of belongs more to the browser than the page ... so it would be a bit strange, if it stayed open with the old tab (if that was even possible technically). But from a usability standpoint, I would prefer this, I guess. ... Second best IMO would be, if the toolbar-menu closes during an automatic tab-switch. ... And third best IMO would be, if the toolbar-menu stays open during the switch (like now), but the links are disabled on the new page.
Just my 2 cents. ;-)
from contextsearch-web-ext.
Going manually to the opened search-tab closes the Toolbar-menu.
This behavior is managed by the browser, not the extension, so as an addon dev, I have no control over the menu closing. So I'd consider that the default behavior i guess?
But going automatically to the new search-tab (with defined mouse-click) the Toolbar-menu stays open during the tab-switch and also in the new tab. ... But there the links are not disabled and one risks clicking them.
Hmm... ok. I'll see if there's a check I can run on new tabs to see if the toolbar menu is open. That may be difficult. That particular browser feature is a bit lacking in access.
from contextsearch-web-ext.
Do you have the option Close menu after performing a search
disabled then? I can't see any other way the menu would stay open after performing a search to a new tab.
from contextsearch-web-ext.
Do you have the option
Close menu after performing a search
disabled then?
Yes, I have it disabled. I like it to stay open for the cases, where I do more than one search. ... it is very handy. ... But it wouldn't need to stay open over in the new tab ... only in the old one.
Hmm... ok. I'll see if there's a check I can run on new tabs to see if the toolbar menu is open. That may be difficult. That particular browser feature is a bit lacking in access.
Again, how about rather closing it in the new tab?
from contextsearch-web-ext.
it wouldn't need to stay open over in the new tab ... only in the old one
Not sure how to implement this. Some users would undoubtedly want the menu to stay open as they send searches to multiple New Tabs. I suppose just an option to close the menu on New Tab searches vs Current Tab
from contextsearch-web-ext.
Some users would undoubtedly want the menu to stay open as they send searches to multiple New Tabs. I suppose just an option to close the menu on New Tab searches vs Current Tab
Yes, I think, you are right: Some users will probably want this.
Well, if an option to close the menu on New Tab searches vs Current Tab is possible, than I am very much for it! ... That is what I like in CS so much anyways: The high configurability. :-)
from contextsearch-web-ext.
Yes, please, a signed beta would be good!
from contextsearch-web-ext.
Ah, wonderful! Thank you!
Looks really good so far.
Will test it further.
from contextsearch-web-ext.
Thank you, Ssborbis!
from contextsearch-web-ext.
Related Issues (20)
- How to click? HOT 14
- Vivaldi - Symbols are not displayed HOT 8
- open search page in a popup window HOT 13
- ContextSearch on other Extension-Pages HOT 10
- Search Engines get automatically added again after being removed
- no double-click event, trigger immediately HOT 2
- search bar not focused in popup menu
- Performance impact Speedometer 3.0 HOT 3
- I need help in Post-Search Script HOT 7
- "Copy to clipboard" tool doesn't work as expected in some cases. HOT 14
- Access pages with the scheme "chrome-extension://": hypothes.is PDF annotations HOT 3
- How to use Bookmarklets with Context Menu? HOT 13
- Auto theming makes the dark mode pale HOT 4
- Search Actions: Open In Current Tab works no more HOT 3
- How to add this searcg engin, it looks rare! HOT 5
- Possibility? Auto-copy image when i use {searchTerms} with context menu? HOT 2
- Feature request: Add option for dictionary popup HOT 3
- How to make a template for a website that doesn't have a searching URL HOT 10
- Version 1.46.25 (latest?) not working HOT 10
- There is no pop-up newtab after my selecting words on any webpage and hitting any search engine on the right-click menu.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contextsearch-web-ext.