Cannot clean notebooks encountering “NotJSONError” with plotly js code inside about nb-clean

[srstevenson]

I'm not able to reproduce this using the same versions of nb-clean and nbformat, either using the Git filter or invoking nb-clean manually:

$ nb-clean check plotly-example-2.ipynb
plotly-example-2.ipynb cell 0: metadata
plotly-example-2.ipynb cell 0: execution count
plotly-example-2.ipynb cell 0: outputs
plotly-example-2.ipynb metadata: language_info.version

However, I'm on Linux whereas you're on Windows and there's a warning from Git that LF line endings will be replaced with CRLF line endings on checkout in your output. To see if the line ending conversion is involved, do you have the same error if you run nb-clean outside the Git filter (nb-clean check plotly-example-2.ipynb)?

[firezym]

I can pass the $ nb-clean check plotly-example-2.ipynb on windows powershell command line too, returning the same results as you.

But when I use $ git add plotly-example-2.ipynb, I still get the same error showing above.

My CRLF setting in the git global config file C:\Users\Administrator\.gitconfig is as following

[core]
	autocrlf = input

Should I alter the autocrlf setting to something else?

[srstevenson]

According to this PR in another project, Jupyter notebooks are always created with LF line endings on Windows. That suggests adding the following to the .gitattributes file in your repository (if you've not worked with the .gitattributes file before, there's documentation on its purpose and the available options here):

*.ipynb  text eol=lf

[srstevenson]

I'll assume configuring .gitattributes worked: if you have any other trouble please open a new issue.