nodeSetup conflicts in multi-project build about gradle-node-plugin

[srs]

Thanks for the bug report. Will try to fix this in the comming week.

----- Original Message -----

From: "John Engelman" [email protected]
To: "srs/gradle-node-plugin" [email protected]
Sent: Friday, February 21, 2014 10:26:41 PM
Subject: [gradle-node-plugin] nodeSetup conflicts in multi-project build (#7)

In a multi-project Gradle build where 2 conditions are met:

1. Multiple projects apply the 'node' plugins &
2. Gradle parallel build mode is activated

The nodeSetup task can error because multiple instances of it could run at the same time. The tasks collide because they both try to extract to the same destination directory.

I've fixed this in my build by applying the plugin to the root project and then configuring all my tasks to depend on nodeSetup in the rootProject and then disabling the nodeSetup in each child project.

This ensures that in any given build there is only 1 nodeSetup that tries to run.

—
Reply to this email directly or view it on GitHub .

[johnrengelman]

There's also an issue where concurrent builds could both be executing the nodeSetup task and they collide.
I would suggest maybe looking into using Gradle's dependency resolution engine to resolve the Node tar file - you'd benefit from their cache control and locking then.
Also, maybe exploding the tar into the local build directory instead of in the file cache.
Finally, configuring some @Input properties on the SetupTask will allow it to only execute when necessary instead of all the time (the output directory is configured, but without at least one task input, the task will always run).

[srs]

Hi. Can you try with the latest code (snapshot) and see if it works better? I have not been able to replicate this behaviour with both the old and the new code.

What version of gradle are you using? Tested both with 1.10 and 1.11.

Also, it is maybe better to unpack node into local build directory instead of the user .gradle directory. Will probably change this, but you could override it with the following code:

 node {
    workDir = file("${project.buildDir}/nodejs")
 }

[johnrengelman]

I was running it with Gradle 1.9. It was happening on every run of our build. In it we have 4 projects that were applying the plugin and we are running with --parallel.

I'll see if I can get to testing the snapshot this weekend.

[srs]

Hi.

I did a release of this plugin today since I will need some fixes for the gradle-grunt-plugin so you can test 0.4 release instead. Will cut a 0.5 relase with --parallel support if I can figure out the best way to solve it.

[johnrengelman]

Ok.
I think your best bet for fixing it would just be to add the npmSetup task to the rootProject instead of the the current project that is applying the plugin (make sure to only add it if it doesn't exist). Then the dependency would just be to the single task instance on the rootProject and everything should work.

That's what I'm doing in my build.

[srs]

Oh, right. That's a good fix. Will try it out.

[srs]

If you want different configuration of the node plugin in different modules you cannot do that with your solution. Think the better one for now is to use local build directory for unpacking nodejs instead of the global one.

[johnrengelman]

ah yeah...I forgot about that scenario.

[srs]

Have not managed to replicate the error, but think it will be safe to use project.buildDir for unpacking of node instead of using the /.gradle directory.

[srs]

I have not seen this problem in any of my production builds. Closing this since it's reather old.