Provide a built-in CLI handler for startup arguments (--squirel-*) about squirrel.windows

[anaisbetts]

Maybe? Send a PR :)

[christianrondeau]

I can do that :) The only thing that still bothers me is where to put that code. I'm still uncomfortable with putting everything in UpdateManager. It's lifetime (and .Dispose() expected call) differs from a "runtime" API such as this one (and #47). Therefore, I'd create a SquirrelApplicationContext. What do you think?

[anaisbetts]

I would put this in a separate class, yeah - it's not a context though, just make a simple static class + method that will parse arguments and return an Enum

[christianrondeau]

Well, I thought of something like this, since first-run and install both require startup arguments:

var squirrelContext = new SquirrelApplicationContext(args);

if(squirrel.HandleInstall(handler));

if(squirrelContext.IsFirstRun)
  ShowSomeMessage();

So if we're to have such a class, why not make it so that it also handles creating the data directories (since that's the typical job of --squirrel-install), and if it knows the data directories, then it should be the main point of access.

But my main reason is that I'm a TDD-maniac, and if I'm to introduce a dependency in my app, I'd like to be able to mock it. Static methods just make my life harder :)

Anyway, I can just send a PR and let you decide what to do with it :)

[anaisbetts]

So if we're to have such a class, why not make it so that it also handles creating the data directories

I'm not super excited about that, let's leave that in UpdateManager.

But my main reason is that I'm a TDD-maniac, and if I'm to introduce a dependency in my app, I'd like to be able to mock it

This method has no state though, what is there to mock? You pass in arguments, it does a thing

[christianrondeau]

It's your project :) As for TDD, I'll end up wrapping it in a class anyway since I don't want to simulate Squirrel's logic in my app, I just want to simulate a state. My test would then look something like:

squirrelContextMock.SetupGet(m => m.IsFirstRun).Returns(true);

rather than passing the actual squirrel arguments. But that's just my own way of working, I won't push it on you!

[anaisbetts]

#72 should cover this