Comments (3)
Thanks for reporting. I'm low on time, but I'm happy to collaborate on a PR if you want to help out. I can issue a new release after we upgraded the dependencies and fixed the vulnerabilities.
Edit: note that we need to make sure that the tests pass – they're currently commented out due to issues with Sauce Labs. Unit and integration tests should pass:
Lines 39 to 40 in deb1a5f
from karma-viewport.
Yeah, sure, happy to help. I'll look at it now and hopefully PR later today.
Good to know about tests (was wondering about why they're commented out). I'll make sure the tests pass and I'll see if I can get it working without Sauce Labs (if that's okay). Was there a reason for choosing Sauce Labs? Not familiar with them so I don't know if there's an advantage to them or something special that they can do... Just wondering
from karma-viewport.
Was there a reason for choosing Sauce Labs? Not familiar with them so I don't know if there's an advantage to them or something special that they can do... Just wondering
The reason to use SauceLabs (or BrowserStack) was to test on browsers that can't be run in headless mode like Internet Explorer 11, which karma-viewport
actually supports. All browsers that are supported were listed in this configuration file. Since IE is history now, I'd say it's okay to replace SauceLabs with the headless strategy you implemented in #660.
from karma-viewport.
Related Issues (12)
- Invalid file type warning HOT 8
- Viewport is not defined in Karma DEBUG RUNNER HOT 10
- No provider for "framework:viewport"! HOT 5
- Debug context middleware not being registered HOT 9
- Is there a good way to test scrolling within the viewport? HOT 3
- Error with PhantomJs HOT 1
- Getting the TypeScript typings to work HOT 25
- 404 for adapter sourcemap. HOT 2
- ReferenceError: viewport is not defined HOT 10
- Source map issues HOT 3
- No window resize event is triggered HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from karma-viewport.