Comments (4)
stephtaylor
commented on August 20, 2024
1
@cm-datrics the changes should be available in 0.7.2 Let me know if you run into any issues.
from react-square-payment-form.
cm-datrics
commented on August 20, 2024
Looking through the source code, I realise this is because I have supplied my own custom methodsSupported prop to the SquarePaymentForm and thus the default methodsSupported (which is responsible for setting the context values from 'loading' to 'ready' or 'unavailable') is now not being called. Perhaps it would be good to still call the default methodsSupported even if a custom prop is supplied - similar to how the paymentFormLoaded default is called even if a paymentFormLoaded prop is supplied.
Happy to raise a PR for this if you think it would be a good idea
from react-square-payment-form.
stephtaylor
commented on August 20, 2024
Hi @cm-datrics, thanks for calling this out. It seems like a good idea to me and I'm happy to review the PR when it's ready.
from react-square-payment-form.
cm-datrics
commented on August 20, 2024
Thanks @stephtaylor , made one here.
from react-square-payment-form.
Related Issues (20)
- Create Nonce outside of SquarePaymentForm Context
- paymentFormLoaded not being invoked properly HOT 1
- Allow calling `setPostalCode` after the payment form has loaded
- No way to change styling of the input field inside the iframe. HOT 1
- [TS] Wrong types for SqContact (in createVerificationDetails)
- npm install fails to fetch artifact
- sandox=false HOT 1
- Support Gift Card payment form HOT 1
- Payment form script loaded multiple times
- Uncaught AnalyticsParametersRequiredError: The Analytics library must be initialized with analyticsParameters to call verifyBuyer HOT 1
- Support calling setPostalCode HOT 1
- CVV Not auto completing when using CreditCardCVVInput HOT 3
- When trying to run the demo the card UI doesn't have input fields HOT 7
- Styling the input fields HOT 1
- Update docs to show how to customize the form HOT 3
- Typescript requires formId and apiWrapper properties to be set HOT 1
- Unable to add line items HOT 2
- disable prop for CreditCardSubmitButton HOT 1
- Expose SquarePaymentForm State as Context HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-square-payment-form.