Comments (12)
Which version of ASM is that MainClassFinder impl using? It could switch to
Spring's repackaged one in org.springframework.asm, which as of 4.0 accepts
1.8 bytecode...
Juergen
On Fri, Oct 11, 2013 at 1:59 AM, Phil Webb [email protected] wrote:
./gradlew clean build fails with an IllegalArgumentException
out of ASM's ClassReader, as called from Boot's MainClassFinder on Java
1.8.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/88
.
from spring-boot.
Thanks @jhoeller. The MainClassFinder
is in spring-boot-loader-tools where we have explicitly avoided using Spring as a dependency up to now. I suppose we could use the same process as the Spring build to repackage the updates to ASM?
from spring-boot.
We keep Spring Framework 4.0's entire version of ASM in source form in
org.springframework.asm within the spring-core module. You could sync it
from there of course... However, maybe a spring-core dependency isn't so
bad either?
Juergen
On Fri, Oct 11, 2013 at 2:26 PM, Dave Syer [email protected] wrote:
Thanks @jhoeller https://github.com/jhoeller. The MainClassFinder is in
spring-boot-loader-tools where we have explicitly avoided using Spring as a
dependency up to now. I suppose we could use the same process as the Spring
build to repackage the updates to ASM?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/88#issuecomment-26133155
.
from spring-boot.
Yeah spring-core maybe isn't such a bad thing to have on the classpath. Thanks.
from spring-boot.
@philwebb How do I test this (it all seems to work with jdk1.8 and Maven)?
from spring-boot.
Looks like this was fixed?
from spring-boot.
Surprised if that's the case. I thought we would need an ASM upgrade.
from spring-boot.
Don't we use the same ASM as Spring (from spring-core)?
from spring-boot.
Looks like @wilkinsona didn't get round to that yet...
from spring-boot.
I did. 629a77c updated MainClassFinder to use Spring's ASM.
from spring-boot.
I thought so, but when I looked at the cli dependencies I saw an asm.jar so I assumed not. Maybe it's still creeping into the cli jar (but not being used)?
from spring-boot.
It's a groovy dependency, so even though we are now using our own Java 8 compatible asm in the loader-tools, the cli will still pull in asm through groovy.
from spring-boot.
Related Issues (20)
- Clarify that all named properties must match for @ConditionalOnProperty to match HOT 2
- Getting 500 instead of 404 with integration tests when updating from Spring Boot 3.1.x to to 3.2.4 HOT 6
- Bump gradle/wrapper-validation-action from 2.1.1 to 2.1.2
- Bump gradle/wrapper-validation-action from 2.1.1 to 2.1.2
- Remove redundant Regex escapes
- Remove redundant Regex escapes
- Remove redundant Regex escapes
- Verify snapshots once they have been deployed
- Verify snapshots once they have been deployed
- Verify snapshots once they have been deployed
- Upgrade to Gradle Enterprise Conventions 0.0.16
- Reference Guides breadcrumb in page headers is not hyperlinked
- Property `logging.threshold.console` is not effective unless set as Java system property HOT 2
- Executable JAR application startup is much slower after 3.2.0 HOT 5
- bootBuildImage with Podman results in socket connection error HOT 11
- Problem with prometheus metrics and mongodb HOT 4
- Upgrade to Gradle Enterprise Conventions 0.0.16
- Upgrade to Gradle Enterprise Conventions 0.0.16
- Rename Antora component from spring-boot to boot
- Manage antora versions using package.json HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-boot.