Comments (5)
Yes, it's meaningless unless the executor is internal. What matters is the configuration of the endpoint's executor. If you look at this.executor
in NioEndpoint
, you should see it using the configured value for its maximum threads.
from spring-boot.
Thanks for the report. The setting is working as expected and Tomcat's thread pool has a max size of 400. The problem is that the metric is incorrect.
I believe that the metric's incorrect due to #36087. It has changed the executor that Tomcat uses so it's no longer internal to the endpoint. This means that it returns -1
for its max threads:
public int getMaxThreads() {
if (internalExecutor) {
return maxThreads;
} else {
return -1;
}
}
from spring-boot.
Thank you for your kind reply. You actually said that Tomcat's maximum number of threads was set to 400, and the metric was incorrect.
But I debugged the part of code you mentioned, and maxThreads is 200. internalExecutor is false as you said. Is the value of 200 here meaningless?
It works normally in 3.2.6.
from spring-boot.
I've opened https://bz.apache.org/bugzilla/show_bug.cgi?id=69133 - if this is resolved, we can switch back to the default executor and set the queue size for #36087 via a normal setter.
from spring-boot.
Tomcat has added a setter to set the maximum queue size. When using this setter, this issue should go away. I've opened #41093 for that.
from spring-boot.
Related Issues (20)
- Allow PemContent.of to work with untrimmed content HOT 8
- Proposal for Content Revision on Wiki - "Spring Boot 3.0 Migration Guide" HOT 1
- Some @ControllerEndpoint and @RestControllerEndpoint infrastructure remains undeprecated
- Allow ContainerConnectionDetailsFactory to match on one of multiple different connection names
- Spring Authorization Server now defaults multipleIssuersAllowed to false and it cannot be easily re-enabled
- Exceeding 32 @SpringBootTest Configurations Causes Netty RejectedExecutionException with WebFlux HOT 5
- Fix documentation links in the README
- Fix documentation links in the README
- Add support for CNB platform API version 0.14
- Constructor binding of EnumMap fails due to missing key type HOT 2
- DynamicPropertyRegistry Values Not Set After Dev Tools Reload for RestartScope Containers
- Upgrade to Spring RESTDocs 3.0.2
- Upgrade to Spring Framework 6.2.0-M6
- Spring Boot 2 datasource can not run with Dockerfile HOT 4
- ClassNotFoundException in JSP compiler after update from Spring Boot 3.3.1 -> 3.3.2 HOT 8
- Broken documentation links HOT 2
- java.lang.LinkageError: loader 'app' attempted duplicate class definition for jakarta.persistence.TemporalType HOT 1
- Has the loading order of springboot3 beans changed? HOT 1
- Wait until spring-boot.rb file is available when updating Homebrew tap
- Spring Boot profiles not respected when fetching configuration files from Spring Cloud Config after native build HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-boot.