Comments (10)
See spring-cloud/spring-cloud-netflix#466
from spring-cloud-openfeign.
Clarification: ut's only a problem if you have both a @FeignClient
and a @Controller
with the same type-level annotation (e.g. if they share an interface). Since this makes very little sense for a real application, it's not super urgent to do anything on our side (and it would take a change in Spring Framework anyway) to support it. Documentation is definitely a good idea if anyone wants to propose a change.
from spring-cloud-openfeign.
Note : in a spring-boot app, it crashes if you have both a @FeignClient and a FeignHystrixCallback implementing the interface because Spring-MVC complains about ambiguous path mapping.
from spring-cloud-openfeign.
Right, yes. That's worth documenting as well: you can't use fallback=
in @FeignClient
if there is a @RequestMapping
on the interface.
from spring-cloud-openfeign.
It also gets scanned by springfox and probably other tools. Lots of worries 😄 ...
from spring-cloud-openfeign.
Yes, when I used swagger and there are two controller and feignclient but accidently they have the same RequestMapping, then there are IllegalStateException: Ambiguous mapping
, and the project failed starting.
from spring-cloud-openfeign.
Hi @OlgaMaciaszek give me something easy so I cam step through a pull and remerge "the right way"
from spring-cloud-openfeign.
@jenimal you can work on this issue.
from spring-cloud-openfeign.
Will be switching it from a documentation-only issue to an enhancement. We think using @RequestMapping
over @FeignClient
interfaces is a bad practice and are going to remove the support for creating Feign clients annotated with @RequestMapping
on interface level.
from spring-cloud-openfeign.
Done with d6783a6.
from spring-cloud-openfeign.
Related Issues (20)
- Default request header headers overwriten with specific client configuration and shared by all clients HOT 1
- PlaytikaOSS feign-reactive does not support spring boot 3.2.x HOT 1
- @PatchMapping and @DeleteMapping insert unwanted slash when using url and specific value HOT 3
- FeignClientFactoryBean dismiss404 default config overrides client-specific config HOT 1
- Multiple implementations of ResponseInterceptor fail to trigger HOT 10
- Want to understand , is Spring Openfeign is in Deprecated path HOT 2
- Maintain the span from HTTP calls using feign clients with micrometer HOT 1
- Micrometer tracing propagation not working when using Spring FactoryBean and Feign HOT 1
- Custom HTTP codes are not supported HOT 1
- B3 span and parentId headers not propagated with spring-cloud-openfeign and brave HOT 1
- Remove unused spring-boot-starter-aop dependency HOT 1
- [sentinel] openfeign+sentinel Error HOT 2
- Spring Boot 3.2.4 (Cloud 2023.0.1) Cannot deserialize "pageable": "INSTANCE" HOT 5
- Issue with registering method parameter hints HOT 3
- Headers annotation not sending headers HOT 2
- Upgrade to fileupload2 HOT 6
- IllegalArgumentException due to null servletRequest for Oauth2AccessTokenInterceptor after Spring Cloud Update HOT 3
- Fallback functionality should be selectively enabled depending on the actual presense of fallback implementation HOT 1
- provide ignore annotation to programmatically ignore method parameter HOT 1
- Support customization of JDK 11+ HttpClient
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-cloud-openfeign.