Unable to set RetryHandler for LBClient when using Feign about spring-cloud-openfeign

[marcolenzo]

An option (maybe not clean) would be to have the SpringLBClientFactory take care of resetting the retry handlers.

@Override
public LBClient create(String clientName) {
    IClientConfig config = factory.getClientConfig(clientName);
    ILoadBalancer lb = factory.getLoadBalancer(clientName);
    LBClient client = LBClient.create(lb, config);
    client.setRetryHandler(new DefaultLoadBalancerRetryHandler(config));
    return client;
}

[spencergibb]

@marcolenzo I wouldn't do new DefaultLoadBalancerRetryHandler(config), but use factory.getInstance(clientName, RetryHandler.class) and have the default be a DefaultLoadBalancerRetryHandler. You could then customize via the normal ribbon customization methods. WDYT?

[codependent]

@marcolenzo @spencergibb Hi! I just found this issue that kind of describes what is happening to me. I was expecting that when there's a failure FeignClients would retry calling another instance of the same microservice in the next available server instead of just failing.

What actually happens is that it responds with an error 500. The following requests will be executed by the non-failing server, which is cool. However, it would be even better that it never failed and retried the operation in the next server. Is it supposed to work that way?

EDIT: I just realized my problem had to do with HystrixFeign configuration: my client had a 1 second timeout that didn't allow the load balancer to have enough time to call the next service. I increased its value and now it works as expected.

hystrix:
  command:
    getImage:
      execution:
        isolation:
          thread:
            timeoutInMilliseconds: 5000

I am still wondering what the role of Feign's Retryer is, though. Since we have Ribbons retry configuration, it's kind of useless, isn't it?

[rozhok]

Seems that it's fixed in 1.1.x branches, see CachingSpringLoadBalancerFactory

[ryanjbaxter]

Can you please try with the latest Spring Cloud release? The retry functionality has been completely rewritten since this issue was opened?

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[spring-projects-issues]

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.