Coder Social home page Coder Social logo

Comments (19)

spencergibb avatar spencergibb commented on June 18, 2024

Is this an enhancement request or are you seeing a problem? We moved to lazy creation because of other problems that are caused when in certain situations (with spring-data).

from spring-cloud-openfeign.

spencergibb avatar spencergibb commented on June 18, 2024

I see you want the client early to check for configuration errors early.

from spring-cloud-openfeign.

spencergibb avatar spencergibb commented on June 18, 2024

We could make it an opt-in setting (something like feign.ribbon.warmup=true). Your impl sounds right, but we could share the service id function.

from spring-cloud-openfeign.

brenuart avatar brenuart commented on June 18, 2024

opt-in seems a good idea to me.
How would you do it? By making the FeignClientFactory a Lifecycle bean whose start() method would conditionally call getObject() to trigger the init?

from spring-cloud-openfeign.

brenuart avatar brenuart commented on June 18, 2024

@spencergibb if our approach sounds good to you, then I can issue a PR to share what we have done. Do I have your go?

from spring-cloud-openfeign.

spencergibb avatar spencergibb commented on June 18, 2024

@brenuart certainly

from spring-cloud-openfeign.

mkostin avatar mkostin commented on June 18, 2024

@spencergibb has it been addressed? Looks like I am hitting the same issue and would love to take a look at either of the approaches mentioned above.

@brenuart could you please share the PR you're referring to or maybe a gist of the initial workaround?

from spring-cloud-openfeign.

spencergibb avatar spencergibb commented on June 18, 2024

No, he has not submitted a PR.

from spring-cloud-openfeign.

christophe-f avatar christophe-f commented on June 18, 2024

Same here. You can create 2 services A & B. If service A make a request to service B using openfeign or spring cloud feign the first request always timeout and fails. After that everything is good.

Apply to both Brixton and Camden version.

from spring-cloud-openfeign.

DustinWang avatar DustinWang commented on June 18, 2024

feign.ribbon.warmup=true

from spring-cloud-openfeign.

christophe-f avatar christophe-f commented on June 18, 2024

FYI, I don't have the issue after upgrading to Dalston.

DynamicServerListLoadBalancer is initialized much faster and don't timeout at the first request. Could it be initialized right after registering to Eureka?

from spring-cloud-openfeign.

baloo2401 avatar baloo2401 commented on June 18, 2024

Well I have the same issue and I am using Dalson

from spring-cloud-openfeign.

Alberthoven avatar Alberthoven commented on June 18, 2024

I am using Dalston.SR1 and I have the same problem too. Any solution?

from spring-cloud-openfeign.

spencergibb avatar spencergibb commented on June 18, 2024

@Alberthoven https://github.com/spring-cloud/spring-cloud-netflix/issues/384#issuecomment-253577717

from spring-cloud-openfeign.

hqxy avatar hqxy commented on June 18, 2024

Will Springcloud.Finchley.RELEASE still have this problem?

from spring-cloud-openfeign.

OlgaMaciaszek avatar OlgaMaciaszek commented on June 18, 2024

Spring Cloud Finchley is no longer supported and we strongly support upgrading it to Hoxton (Greenwich is no longer supported either). @hqxy Please verify if the issue still occurs in Hoxton.SR3 (you can also switch to a different LoadBalancer implementation then and, thus, different way of creating Feign LB clients by setting spring.cloud.loadbalancer.ribbon.enabled to false ). Let me know if that helps.

from spring-cloud-openfeign.

ffyyhh995511 avatar ffyyhh995511 commented on June 18, 2024

i am facing same issue. my project info is Hoxton.SR9、Supported Boot Version: 2.3.5.RELEASE

from spring-cloud-openfeign.

ffyyhh995511 avatar ffyyhh995511 commented on June 18, 2024

feign.ribbon.warmup=true

it does not work by spring cloud Hoxton.SR9 and springboot 2.3.5.RELEASE

from spring-cloud-openfeign.

OlgaMaciaszek avatar OlgaMaciaszek commented on June 18, 2024

Closing as issue related to Ribbon, which is no longer supported.

from spring-cloud-openfeign.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.