Comments (19)
Is this an enhancement request or are you seeing a problem? We moved to lazy creation because of other problems that are caused when in certain situations (with spring-data).
from spring-cloud-openfeign.
I see you want the client early to check for configuration errors early.
from spring-cloud-openfeign.
We could make it an opt-in setting (something like feign.ribbon.warmup=true
). Your impl sounds right, but we could share the service id function.
from spring-cloud-openfeign.
opt-in seems a good idea to me.
How would you do it? By making the FeignClientFactory
a Lifecycle
bean whose start()
method would conditionally call getObject()
to trigger the init?
from spring-cloud-openfeign.
@spencergibb if our approach sounds good to you, then I can issue a PR to share what we have done. Do I have your go?
from spring-cloud-openfeign.
@brenuart certainly
from spring-cloud-openfeign.
@spencergibb has it been addressed? Looks like I am hitting the same issue and would love to take a look at either of the approaches mentioned above.
@brenuart could you please share the PR you're referring to or maybe a gist of the initial workaround?
from spring-cloud-openfeign.
No, he has not submitted a PR.
from spring-cloud-openfeign.
Same here. You can create 2 services A & B. If service A make a request to service B using openfeign or spring cloud feign the first request always timeout and fails. After that everything is good.
Apply to both Brixton and Camden version.
from spring-cloud-openfeign.
feign.ribbon.warmup=true
from spring-cloud-openfeign.
FYI, I don't have the issue after upgrading to Dalston.
DynamicServerListLoadBalancer is initialized much faster and don't timeout at the first request. Could it be initialized right after registering to Eureka?
from spring-cloud-openfeign.
Well I have the same issue and I am using Dalson
from spring-cloud-openfeign.
I am using Dalston.SR1 and I have the same problem too. Any solution?
from spring-cloud-openfeign.
@Alberthoven https://github.com/spring-cloud/spring-cloud-netflix/issues/384#issuecomment-253577717
from spring-cloud-openfeign.
Will Springcloud.Finchley.RELEASE still have this problem?
from spring-cloud-openfeign.
Spring Cloud Finchley is no longer supported and we strongly support upgrading it to Hoxton (Greenwich is no longer supported either). @hqxy Please verify if the issue still occurs in Hoxton.SR3
(you can also switch to a different LoadBalancer implementation then and, thus, different way of creating Feign LB clients by setting spring.cloud.loadbalancer.ribbon.enabled
to false
). Let me know if that helps.
from spring-cloud-openfeign.
i am facing same issue. my project info is Hoxton.SR9、Supported Boot Version: 2.3.5.RELEASE
from spring-cloud-openfeign.
feign.ribbon.warmup=true
it does not work by spring cloud Hoxton.SR9 and springboot 2.3.5.RELEASE
from spring-cloud-openfeign.
Closing as issue related to Ribbon, which is no longer supported.
from spring-cloud-openfeign.
Related Issues (20)
- FeignClientFactoryBean dismiss404 default config overrides client-specific config HOT 1
- Multiple implementations of ResponseInterceptor fail to trigger HOT 10
- Want to understand , is Spring Openfeign is in Deprecated path HOT 2
- Maintain the span from HTTP calls using feign clients with micrometer HOT 1
- Micrometer tracing propagation not working when using Spring FactoryBean and Feign HOT 1
- Custom HTTP codes are not supported HOT 1
- B3 span and parentId headers not propagated with spring-cloud-openfeign and brave HOT 1
- Remove unused spring-boot-starter-aop dependency HOT 1
- [sentinel] openfeign+sentinel Error HOT 2
- Spring Boot 3.2.4 (Cloud 2023.0.1) Cannot deserialize "pageable": "INSTANCE" HOT 5
- Issue with registering method parameter hints HOT 3
- `FeignClientsRegistar` fails when trying to parse unresolved property placeholders in JDK 20+ HOT 1
- "text/plain" Not working when dealing with the ISO_8859_1 HOT 1
- feign.codec.EncodeException: null HOT 3
- RequestInterceptor not injecting headers after upgrading it to 2023.0.1
- Default http client (Client.Default) seems not taking 'spring.cloud.openfeign.httpclient' properties when creating feign client with FeignClientBuilder HOT 1
- FeignClients auto config
- Unable to read the totalElements property of Page from Spring Data Commons 3.3.0
- Client delegation stopped working
- disableSslValidation not working in spring cloud. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-cloud-openfeign.