Jquery Rating Plugin Not 1.9 compatible about spree_reviews

[radar]

I would rather we didn't use the jquery.migrate kludge. jQuery removed those helpers for a reason and so we shouldn't be forcing them back in. Let's fix this extension instead.

[iloveitaly]

The jQuery rating library used in this plugin is pretty out of date (hasn't been updated in close to a year).

What do you think about moving to a more maintained rating library (https://github.com/wbotelhos/raty)?

[radar]

I think that would be a good move. Could you please look into this?

[iloveitaly]

I don't think I'll have time within the next month, but as soon as I find time I'll look into it.

On Feb 6, 2013, at 5:29 PM, Ryan Bigg [email protected] wrote:

I think that would be a good move. Could you please look into this?

—
Reply to this email directly or view it on GitHub.

[yuji101]

I think this libraly(https://github.com/bmc/jquery-raty-rails) is useful for the move.

Maybe, it will work with the code like below.

_stars.html.erb

<% if defined? edit_enabled %>
    <div data-score="0" class="raty-star vote-star" > </div>
<%  else  %>
    <div data-score="<%= stars %>" class="raty-star readonly-star" > </div>
<%  end %>

js file

jQuery(document).ready(function($){
    $('.raty-star').raty();
    $('.readonly-star').raty('readOnly', true);

    $('.vote-star').raty({
      cancel: true,
      score: function() {
        return $(this).attr('data-score');
      }
    });

    $("input[name=score]").first().attr('name',"review[rating]");
});

[JDutil]

@yuji101 would you mind putting together a PR?

[JDutil]

Actually I would not recommend using that gem @yuji101 it is not very active, and would probably be best to simply use the jquery library itself as @iloveitaly mentioned.

[yuji101]

I think original raty perhaps don't work well with spree on rails , so I mentioned jquery-raty-rails.
Please use the gem and the code I commented as reference for improving spree_reviews.
I don't have enough time for putting together it now.

[createthis]

Maybe the best solution is to just implement Modernizr instead of jQuery.browser as suggested by the jQuery 1.9 upgrade guide: http://jquery.com/upgrade-guide/1.9/#jquery-browser-removed

[navygator]

http://www.fyneworks.com/jquery/star-rating/ updated to works with 1.9

[JDutil]

Thanks @navygator for pointing that out. I've updated master w/ae1aa207f9fd9b0c9be297a1228bd98df5255978 and 2-0-stable and 1-3-stable to use the latest jquery.rating plugin for 1.9 compatibility.