missing translations about spree_globalize

[tvdeyen]

Yes. I think they should be in this gem. Could you send us a pull request? That would be great. Thanks.

[tvdeyen]

I guess they are still in the spree_i18n gem. Right @alepore ?

[alepore]

yeah, we should probably move all the i18n.* keys here, maybe renaming them to globalize: ?

[alepore]

uhm, some keys are used both on i18n and globalize...

[tvdeyen]

I would say copy them over. Spree translation keys are too generic in most cases anyway. And it doesn't hurt to have some of them duplicated.

What keys are we talking about?

[alepore]

https://github.com/spree/spree/blob/master/core/config/locales/en.yml#L721 (yes, english is on the core.....)

[alepore]

I'd copy only the keys that are only here... or just leave them on i18n, they are just 4-5 keys.

[alepore]

to sum up, a nice work would be to move these keys from i18n to this gem, for all languages, and change the namespacing to globalize on templates:

en:
  spree:
    globalize:
      fields:
      locales_displayed_on_translation_forms:
      only_complete:
      only_incomplete:
      select_locale: 
      show_only: 
      supported_locales:
      translations:

i started with actually missing stuff: https://github.com/spree-contrib/spree_globalize/blob/master/config/locales/en.yml