Coder Social home page Coder Social logo

Comments (3)

LeifW avatar LeifW commented on June 16, 2024 1

I'm used to "codec"s for thing in the stdlib (like tuples) already being included in a library like this out of the box - without having to "derive" them. E.g. circe generates codecs for Tuples 1-22 here: https://github.com/circe/circe/blob/series/0.14.x/project/Boilerplate.scala#L157
Saves time over doing that at compile time for library users, also.
Would you accept a PR for adding instances for tuples like that - perhaps using sbt-boilerplate?

from magnolify.

RustedBones avatar RustedBones commented on June 16, 2024 1

Ok I get it now. We handle tuple like other generic products instead of providing a default implicit.

If we add those, we should do the same in all magnolify modules. So far most of other modules are not affected by this because there is no semiauto/auto separation. IMHO we should do this split AND provide tuple implicits for the semiauto package.

I think it is worth a discussion and gathering other opinion before you get started :) cc: @spotify/flatmap

from magnolify.

RustedBones avatar RustedBones commented on June 16, 2024

Hi @LeifW, sorry for the late answer.

implicitly[Funnel[(String, String)]]

won't work with semiauto. You should either use auto to retrieve the funnel implicitly or create it explicitly with

FunnelDerivation[(String, String)]

Concerning the implicit conflict for List[(String, String)], we indeed have a problem with implicit priorities. Will create a patch

from magnolify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.