nba_leaguegamelog function 400 error when running on Mac about hoopr

[murrayjw]

I was having the same problem and had a quick look at the code. Looks like the problem is coming from a new default argument (params = list()) that was added to the .nba_headers() function. That function uses httr::GET to request the data from the API. The params argument is passed to httr::GET in the query argument but it is empty for the nba_leaguegamelog function. If you remove the query argument the data is returned as it was before.

So if this:

res <- httr::RETRY("GET", url, query = params, httr::add_headers(.headers = headers))

is changed to this:

if(length(params) == 0) {
   res <- httr::RETRY("GET", url, httr::add_headers(.headers = headers))
} else {
    res <- httr::RETRY("GET", url, query = params, httr::add_headers(.headers = headers))
}

in the .nba_headers() function, everything works. The params argument gets used elsewhere (e.g. hoopR::nba_scoreboard. so you need some logic to deal with the case where params are empty

[schmid07]

It looks like when I ran on Windows (where it was working), I was using version 1.5.0 of hoopR. When I switched to 1.8.0, I got the same error message as when running on Mac. And when I switched back to 1.5.0 on the Mac, the function worked. So it seems like the function works in v. 1.5.0, but was having some issues with 1.7.0 and then also when I updated to 1.8.0.

Thanks.

[saiemgilani]

You're a lifesaver, thanks

[murrayjw]

No problem! Anytime