Comments (3)
It depends on how users utilize the Spore SDK.
If we only require Spore SDK methods and not other Lumos methods, then installing the Spore SDK is better.
However, if we need other CKB-related methods in most situations when using Spore SDK, then it's more flexible to use peerDependencies
with a ranged version. This approach would be beneficial since we only need one Lumos in the build to create a lighter production build.
BTW, Lumos has refactored the entry package @ckb-lumos/lumos
from 0.22, and we don't need to import several child packages in most cases. This will make it simpler when Spore SDK chooses the peerDependencies
solution
spore-sdk/packages/core/package.json
Lines 20 to 26 in 6c57341
from spore-sdk.
@ShookLyngs this issue gets a potential resolution for a better experience?
from spore-sdk.
this issue gets a potential resolution for a better experience?
For now, I suggest we keep the lumos family in the dependencies
. Moving them to peerDependencies
can potentially introduce other unexpected issues for developers (too many peer dependencies), which is not our intention.
Regarding the improvement resolution, as homura mentioned, if we can reduce the lumos-related dependency count in the spore-sdk, such as only having @ckb-lumos/lumos
as a dependency, we can consider moving it to the peerDependencies
. This change is unlikely to cause troubles for developers.
from spore-sdk.
Related Issues (20)
- The `injectCapacityAndPayFee` method has an unnecessary prop
- Feature limitation for different versions of type scripts HOT 1
- The error messages for checking the type of the target cell need improvement. HOT 3
- Automatically test the SDK with GitHub Actions HOT 3
- Should use Uint8 for ClusterAgentArgs.minPayment
- Need to complete Github CI test in native CKB node
- Co-build intergration
- Rewrite on-chain transaction-related tests HOT 3
- Remove `minPayment` from the transferClusterProxy API
- An unexpected null reading issue in test ci HOT 1
- Select default scripts by tags
- Maintain an api-doc for sdk utilities
- Deprecating `predefinedSporeConfigs.Aggron4`
- Automatically search all of Spore cells with different code hashes HOT 2
- Duplicated capacity colelction
- Report the needed CKB if transaction failed with insufficient capacity HOT 1
- Add a new interface to construct one transaction that combines Spore `melt` and `mint` operations simultaneously HOT 1
- Add method to generated DOB/0 pattern data HOT 1
- `meltThenCreateSpore` API should optimize the handling of margin capacity
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spore-sdk.