Comments (5)
The requested change necessitates a change in the explanation for the stopFilter method. Based on the original comment and the JavaDocs, the following statement:
The BlockRayBuilder#stopFilter stops the ray cast when it hits a block that passes the given filter and the BlockRayBuilder#skipFilter skips all blocks that pass the filter.
should read
The BlockRayBuilder#stopFilter continues the ray cast when it hits a block that passes the given filter and the BlockRayBuilder#skipFilter skips all blocks that pass the filter.
Otherwise, the code example contradicts the explanation. With the example given, the explanation says the trace stops when it encounters an air block.
I am requesting a review by the @SpongePowered/developers team to ensure my proper understanding before making the changes.
Note to self: Add a space between convenience,
and ``BlockRay``
on line 44.
from spongedocs.
I'm sorry, @ST-DDT, for not responding. I adjusted some GitHub settings, so I didn't get an email about this. And, I haven't been on GitHub while I have been adjusting to a new job.
from spongedocs.
from spongedocs.
It's been merged already, probably can be closed.
from spongedocs.
@Grauldon Any update on this one?
from spongedocs.
Related Issues (20)
- A spelling mistake in ZHCN page of plugin/configuration/index . HOT 2
- Add documentation about messaging channels
- Add language tabs on code blocks HOT 2
- Track Enhancements of Debugging Documentation HOT 3
- Documenting system properties HOT 4
- Windows shell issue resolved, should be documented HOT 4
- Debugging tutorial is overcomplicated HOT 6
- Plundering the SpongeCommon Wiki HOT 2
- Active Page on PaginationService HOT 1
- Document or link to Ore 2.0 API HOT 3
- Outdated information on Ore Publishing Guide
- Add documentation for "Incompatible" mods HOT 11
- Recommend a specific version of gradle
- Mixins Fail to apply, causing client to crash upon joining a world
- ContextCalculator docs state it must be thread safe, but use a potentially unsafe example HOT 3
- [API-8] Docs Update Tracker HOT 2
- References to outdated maven repo
- Gradle page needs updating
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spongedocs.