Coder Social home page Coder Social logo

Comments (5)

Grauldon avatar Grauldon commented on July 26, 2024 3

The requested change necessitates a change in the explanation for the stopFilter method. Based on the original comment and the JavaDocs, the following statement:

The BlockRayBuilder#stopFilter stops the ray cast when it hits a block that passes the given filter and the BlockRayBuilder#skipFilter skips all blocks that pass the filter.

should read

The BlockRayBuilder#stopFilter continues the ray cast when it hits a block that passes the given filter and the BlockRayBuilder#skipFilter skips all blocks that pass the filter.

Otherwise, the code example contradicts the explanation. With the example given, the explanation says the trace stops when it encounters an air block.

I am requesting a review by the @SpongePowered/developers team to ensure my proper understanding before making the changes.

Note to self: Add a space between convenience, and ``BlockRay`` on line 44.

from spongedocs.

Grauldon avatar Grauldon commented on July 26, 2024 2

I'm sorry, @ST-DDT, for not responding. I adjusted some GitHub settings, so I didn't get an email about this. And, I haven't been on GitHub while I have been adjusting to a new job.

from spongedocs.

JBYoshi avatar JBYoshi commented on July 26, 2024 1

https://github.com/SpongePowered/SpongeAPI/blob/b38390e1751fff802d355155c45b2eb4913f5817/src/main/java/org/spongepowered/api/util/blockray/BlockRay.java#L354-357

from spongedocs.

dualspiral avatar dualspiral commented on July 26, 2024 1

It's been merged already, probably can be closed.

from spongedocs.

ST-DDT avatar ST-DDT commented on July 26, 2024

@Grauldon Any update on this one?

from spongedocs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.