broadcastMessage() Overloads about spongeapi

[Mumfrey]

I think it's entirely possible that the overloads on Player.sendMessage() may go since they're redundant. Message already implements Iterable<Message> anyway and the String overload doesn't really make sense anyway since it just forces the server to wrap the String in a Message object internally. If anything, Player.sendMessage should be unified with Game.broadcastMessage()

[nightpool]

@Mumfrey so things like player.sendMessage("Hi! Welcome to our server");
shouldn't work? That sounds like its introducing another layer or
complexity where it really doesn't need to be to me...

On Mon, Dec 15, 2014 at 11:40 AM, Mumfrey [email protected] wrote:

I think it's entirely possible that the overloads on Player.sendMessage()
may go since they're redundant. Message already implements
Iterable anyway and the String overload doesn't really make
sense anyway since it just forces the server to wrap the String in a
Message object internally. If anything, Player.sendMessage should be
unified with Game.broadcastMessage()

—
Reply to this email directly or view it on GitHub
#287 (comment)
.

[Soren025]

@nightpool that would be player.sendMessage(Massages.of("Hi! Welcome to our server")); without the overloads

[nightpool]

@Soren025 Right, but that's another API to learn and another Class' javadoc
to look at. Seems like a pointless change that makes things harder on API
consumers to me. What's the problem with maintaining a sendMessage
overload? (and making a comparable broadcastMessage one of course)

On Mon, Dec 15, 2014 at 9:00 PM, Soren025 [email protected] wrote:

@nightpool https://github.com/nightpool that would be player.sendMessage(Massages.of("Hi!
Welcome to our server")); without the overloads

—
Reply to this email directly or view it on GitHub
#287 (comment)
.

[Zidane]

...because Minecraft's chat system doesn't work like this anymore. The API should serve to teach the plugin developer that yes there is formatting, styles, etc. Instead of masking it behind the scenes by having the server make the message object.

[nightpool]

@Zidane but that's what the overload is there for?

Okay anyway it doesn't matter THAT much I'm not looking to start a religious war over this.

[JonathanBrouwer]

I think the best is to have both a sendMessage for String, and Message

[Sannholm]

I agree with Zidane and think there should only be a sendMessage for Messages. And people can make their own helper methods for Strings, if they need to.

[maxov]

Closing in favor of #425