Comments (11)
@mvpgomes thank you for this! I've submitted a PR: #160
from ruby-client.
@mvpgomes ok, I'll let you steal my thunder this time :D
But please, target development
branch
from ruby-client.
@maksimf thank you, I already created a PR too #159 💃
from ruby-client.
At CustomInk we have quite a few applications that are in debt with Faraday pegged at ~> 0.8
. Most of our newer internal client gems test Faraday from that version up to 0.11
IIRC using the Appraisal gem. Given that, two questions:
- Is there a version of this gem that can use an older Faraday gem?
- If not, is there any appetite to building this gem in such a way that works and is test with older Faraday gems?
from ruby-client.
Let me investigate on that
from ruby-client.
@metaskills After some research I've figured that we can't use faraday_middleware
at 0.8
now, because we need FaradayMiddleware::Gzip
. I think I'll find the solution how to deal with it though. I'll keep you posted here
from ruby-client.
because we need FaradayMiddleware::Gzip
Is that true? I was looking at the source (https://github.com/lostisland/faraday_middleware/blob/master/lib/faraday_middleware/gzip.rb) and it has the following comments:
# This middleware is NOT necessary when these adapters are used:
# - net_http on Ruby 1.9+
# - net_http_persistent on Ruby 2.0+
# - em_http
from ruby-client.
from ruby-client.
Hey @metaskills! I got rid of faraday_middleware
completely and now we depend on faraday >= 0.8, so you should be fine, please confirm
from ruby-client.
I can confirm that we can now bundle the latest 4.2.0 to our legacy application(s).
from ruby-client.
Awesome!
from ruby-client.
Related Issues (20)
- JRuby support HOT 4
- [redacted] please ignore
- [redacted]
- cache_ttl in consumer mode HOT 1
- splits_repository.splits is significantly more costly than splits_repository.split_names HOT 2
- `fix_latencies` is running every restart by each app server, affecting Redis performance HOT 4
- Occasionally split_manager returns empty list of splits HOT 15
- Redis.exists? deprecation warning from redis v4.2.2 HOT 3
- block_until_ready doesn't timeout if the api key is invalid HOT 9
- Quickstart: SDK Setup code does not work HOT 4
- 7.2.3 performance issues HOT 5
- High CPU usage on wrong split key HOT 4
- Update Rake version to support development on Ruby 3 HOT 2
- Update CI to target non-EOL Ruby HOT 2
- Split logger errors HOT 2
- SDK not sync configuration changes in Rails console HOT 3
- Faraday 2.0+ compatibility HOT 5
- Splitio: #IOError: stream closed in another thread HOT 5
- Stream Event Parsing Silently Failing and Not Falling Back to Polling HOT 3
- Error during a parsing event HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ruby-client.