HTTP requests failing when faraday_middleware version < 0.10 about ruby-client

[maksimf]

@mvpgomes thank you for this! I've submitted a PR: #160

[maksimf]

@mvpgomes ok, I'll let you steal my thunder this time :D
But please, target development branch

[mvpgomes]

@maksimf thank you, I already created a PR too #159 💃

[metaskills]

At CustomInk we have quite a few applications that are in debt with Faraday pegged at ~> 0.8. Most of our newer internal client gems test Faraday from that version up to 0.11 IIRC using the Appraisal gem. Given that, two questions:

• Is there a version of this gem that can use an older Faraday gem?
• If not, is there any appetite to building this gem in such a way that works and is test with older Faraday gems?

[maksimf]

Let me investigate on that

[maksimf]

@metaskills After some research I've figured that we can't use faraday_middleware at 0.8 now, because we need FaradayMiddleware::Gzip. I think I'll find the solution how to deal with it though. I'll keep you posted here

[metaskills]

because we need FaradayMiddleware::Gzip

Is that true? I was looking at the source (https://github.com/lostisland/faraday_middleware/blob/master/lib/faraday_middleware/gzip.rb) and it has the following comments:

# This middleware is NOT necessary when these adapters are used:
# - net_http on Ruby 1.9+
# - net_http_persistent on Ruby 2.0+
# - em_http

[maksimf]

I've seen this as well, but no, it doesn't work without it :-(

[maksimf]

Hey @metaskills! I got rid of faraday_middleware completely and now we depend on faraday >= 0.8, so you should be fine, please confirm

[metaskills]

I can confirm that we can now bundle the latest 4.2.0 to our legacy application(s).

[maksimf]

Awesome!