Coder Social home page Coder Social logo

Comments (14)

mfridman avatar mfridman commented on June 27, 2024 2

Can confirm its working as expected and I'm seeing the correct module version in my go.mod files

- github.com/speps/go-hashids v2.0.0+incompatible
+ github.com/speps/go-hashids/v2 v2.0.1

from go-hashids.

mfridman avatar mfridman commented on June 27, 2024 2

@dolmen likewise we use this in production across a few projects. So if you need an extra set of eyes on a PR and/or benchmarking help would be happy to assist, feel free to ping me.

from go-hashids.

speps avatar speps commented on June 27, 2024 1

Thanks for the instructions Olivier, would you want rights on this repo to maintain it a little bit? There isn't much to do usually but I don't have a Go setup anymore to actually do this kind of thing easily.

from go-hashids.

dolmen avatar dolmen commented on June 27, 2024

OK for being maintainer.

from go-hashids.

mfridman avatar mfridman commented on June 27, 2024

+1 for this. Tripped me up a bit seeing v2 but not being able to fetch it. Happy to help as well if needed.

go get: module github.com/speps/go-hashids@upgrade found (v2.0.0+incompatible), but does not contain package github.com/speps/go-hashids/v2

from go-hashids.

Velocity- avatar Velocity- commented on June 27, 2024

Pinging @speps - might be a good idea to give rights to @dolmen so that this repo keeps pace, even if a little. It's the linked one from the hashids website so it's good for the ecosystem.

from go-hashids.

speps avatar speps commented on June 27, 2024

I did send an invite to get @dolmen as a collaborator but it wasn't accepted yet.

from go-hashids.

mfridman avatar mfridman commented on June 27, 2024

@speps I'd be happy to pitch in and help maintain the repo if needed, I do quite a bit of Go development nowadays and have an environment readily available.

Otherwise, I hope @dolmen accepts given they contributed to this repo in the past :)

from go-hashids.

speps avatar speps commented on June 27, 2024

As the contributors page shows, @dolmen sent 6 PRs before and is the second main contributor hence why I didn't mind giving full access. I will gladly accept a PR from you of course, no need to have full access :)

from go-hashids.

mfridman avatar mfridman commented on June 27, 2024

Of course, totally understand.

I've created a PR #58. Once its merged we'll need a v2.0.1 tag. I have a few dependencies on this project so will verify its working as expected as a consumer of this package with the latest changes.

from go-hashids.

speps avatar speps commented on June 27, 2024

Thanks @mfridman, it's now merged and a new v2.0.1 tag was made.

from go-hashids.

dolmen avatar dolmen commented on June 27, 2024

@speps Could you resend the invitation, please?

I'm using this module in production, and I have some short terms plan to improve the implementation for speed.

from go-hashids.

dolmen avatar dolmen commented on June 27, 2024

@speps Could you resend the invitation, please?

from go-hashids.

speps avatar speps commented on June 27, 2024

Sent

from go-hashids.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.