org-alert breaks the agenda about org-alert

[leungbk]

@spegoraro I'd be willing to take over the project if you've too little time on your hands.

[spegoraro]

Hi, thanks for reporting. I haven't been able to replicate the issue but please try master now. I have merged #16 from @PierreTechoueyres which re-builds the agenda if a buffer exists so it may resolve what you're seeing.

[chase-dwelle]

I can confirm that this is also happening for me using org-alert-20180523.1833 from MELPA.

[PierreTechoueyres]

Hi @chase-dwelle,
Could you try with redefining org-alert-check like bellow:

(defun org-alert-check ()
  "Check for active, due deadlines and initiate notifications."
  (interactive)
  ;; avoid interrupting current command.
  (unless (minibufferp)
    (let ((org-agenda-saved-buffer (and org-agenda-buffer (buffer-name org-agenda-buffer))))
      (save-window-excursion
	(save-excursion
          (save-restriction
            (let ((active (org-alert--filter-active (org-alert--get-headlines))))
              (dolist (dl (org-alert--strip-states active))
		(alert dl :title org-alert-notification-title))))))
      (when org-agenda-saved-buffer
	(ignore-errors
    	  (with-current-buffer org-agenda-saved-buffer
    	    (org-agenda-redo t)))))))

If this correct your problem, I'll propose a new PR to fix this.

[chase-dwelle]

That works but opens a new org-agenda buffer called *temp*, with the agenda functionality intact.

[PierreTechoueyres]

I can't reproduce the creation of *temp* buffer.
How do you open the agenda buffer ? What's your version of org mode and Emacs ?

[chase-dwelle]

Ah, the *temp* buffer is only created when I'm in one of my custom agenda layouts. The solution works for the "standard" org-agenda.

[PierreTechoueyres]

Could you try the version bellow:

(defun org-alert-check ()
  "Check for active, due deadlines and initiate notifications."
  (interactive)
  ;; avoid interrupting current command.
  (unless (minibufferp)
    (let ((org-agenda-saved-buffer (and org-agenda-buffer (buffer-name org-agenda-buffer))))
      (save-window-excursion
	(save-excursion
          (save-restriction
            (let ((active (org-alert--filter-active (org-alert--get-headlines))))
              (dolist (dl (org-alert--strip-states active))
		(alert dl :title org-alert-notification-title))))))
      (when org-agenda-saved-buffer
	(ignore-errors
    	  (with-current-buffer org-agenda-saved-buffer
    	    (org-agenda-redo-all t)))))))

[chase-dwelle]

Still get the same behavior, duplicating the agenda into a *temp* buffer, unfortunately.

[PierreTechoueyres]

And this one ?

(defun org-alert-check ()
  "Check for active, due deadlines and initiate notifications."
  (interactive)
  ;; avoid interrupting current command.
  (unless (minibufferp)
    (let ((org-agenda-saved-buffer (and org-agenda-buffer (buffer-name org-agenda-buffer))))
      (save-window-excursion
	(save-excursion
          (save-restriction
            (let ((active (org-alert--filter-active (org-alert--get-headlines))))
              (dolist (dl (org-alert--strip-states active))
		(alert dl :title org-alert-notification-title))))))
      (when org-agenda-saved-buffer
	(ignore-errors
    	  (with-current-buffer org-agenda-saved-buffer
    	    (let ((org-agenda-this-buffer-name org-agenda-this-buffer-name))
	      (org-agenda-redo t))))))))

[chase-dwelle]

Same thing. This is the custom view I'm using:

(setq org-agenda-custom-commands
      '(
        ;; Daily agenda perspectives
        ("d" . "Daily perspectives")    ;Label for daily perspectives.
        ("da" "Daily priority agenda"
         ((tags-todo "SCHEDULED<\"<+1d>\"&PRIORITY=\"A\"" ;Priority tasks available to do today
                     ((org-agenda-skip-function '(org-agenda-skip-entry-if 'todo 'done))
                      (org-agenda-overriding-header "High-priority unfinished tasks:")))
          (agenda "" ((org-agenda-span 'day)
                      (org-scheduled-delay-days -14)))
          (tags-todo "SCHEDULED<\"<+1d>\"" ;All tasks available today
                     ((org-agenda-skip-function '(or (org-agenda-skip-entry-if 'todo 'done)
                                                     (air-org-skip-subtree-if-priority ?A)))
                      (org-agenda-overriding-header "Available tasks:")))))))

[PierreTechoueyres]

I think I won't be able to provide a better solution.
I think also that the right thing to do is to use the solution provided by @jakecoble in PR #17.

[jakecoble]

@chase-dwelle What versions of Emacs and org are you using?

[chase-dwelle]

I'm using Emacs 26.1 and org 9.1.13 from elpa.

[jakecoble]

I think this deserves more attention, and I’ll look into it. As much as I like my solution, I don’t think we should merge a breaking change for a bug we haven’t been able to replicate yet.

@chase-dwelle For now, I suggest use my fork if it works around your problem (I’m currently running it successfully with Emacs 26 and org 9.)

[MCSH]

Did you found any solutions for the rename of the custom agenda buffer to *temp*? I don't mind not being the default name, but I would prefer something that I can find in the buffers, like *temp agenda* at least.

[spegoraro]

Unfortunately I've had very little time to work on this project, if anybody would like to take over maintenance I'll happily send the repo over. Otherwise at best I can have a look next month.

[ntBre]

I think this should be taken care of after the restructuring from #17, but I will be happy to reopen it if not.