Coder Social home page Coder Social logo

Comments (2)

eduardoboucas avatar eduardoboucas commented on May 20, 2024

Every profile has a directory with an index.html inside, so the correct URL for profile something will be http://root.url/something. This is totally fine if you use a custom domain and the site sits at the root of the domain (e.g. http://demo.speedtracker.org).

The issue here comes when the root of your dashboard is on a sub-directory (e.g. http://yourusername.github.io/speedtracker). Switching to profile something should link to http://yourusername.github.io/speedtracker/something, but it's blindly linking to /something, which means the end URL will be http://yourusername.github.io/something, which obviously isn't valid.

I don't think the solution to this is the introduction of a query parameter, as Jekyll wouldn't be able to read this. The profile selector just needs to form the URL correctly. There is a window.BASE_URL which contains the relative path to the root, which we can use to properly build the URLs.

I will close #8 as I don't think it's the right approach, and will look into fixing this asap (and coming up with a good versioning system and a way for people to update their dashboards).

Thanks for flagging this!

from speedtracker.

mathieuhays avatar mathieuhays commented on May 20, 2024

makes sense :)

from speedtracker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.