Trailing Slash is removed about url

[stefanbauer]

Yeah, 100% agree with @nyamsprod - the rtrim should be removed imho, as http://example.com/sub and http://example.com/sub/ are two different but valid locations. I think it doesn't break anything if we just remove the rtrim, does it?

[stefanbauer]

Totally get it and understand it. I extended it for now and override this part. Will create a PR that fixes that as soon as I have some time. But dunno when. Thanks for your reply @sebastiandedeyne

[sebastiandedeyne]

Hmm I think I blame Guzzle here but I understand the frustration.

I'd accept a non-breaking PR that keeps the trailing slash if it's initially passed. Not sure if this is gonna be easy though.

[nyamsprod]

@sebastiandedeyne the question is why is this package removing the trailing slash from the path. it is true that http://example.com and http://example.com/ may be considered equal but http://example.com/v1/ and http://example.com/v1 can not.
By removing the trailing slash you are directly feeding wrong information to any package that will use URL resolution according to RFC3986 which is what Guzzle is doing.
So the only resolution for this bug is to remove the rtrim usage in the library. But If I understand it correctly this would mean introducing a BC break.

[sebastiandedeyne]

the question is why is this package removing the trailing slash from the path

It's been too long. I remember it made some parts of the package easier to have everything consistent, but don't remember where.

I'm willing to review PR that removes rtrim and fixes whatever needs to be fixed, but at the moment I don't have time to work on this myself, sorry!

[spatie-bot]

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.