Hidden files are not deleted about laravel-directory-cleanup

[freekmurze]

Feel free to submit a PR with tests that fixes this

[bluec]

Ok I can see why this is happening but have a question because fixing it may cause people some problems when they upgrade.

First, the reason it happens is because \Illuminate\Filesystem\Filesystem allFiles() method has the following signature

    public function allFiles($directory, $hidden = false)

But DirectoryCleaner calls the method without the second parameter so hidden files are never included in the file list collections.

If we alter (fix) this behaviour then the default DeleteEverything policy will then delete hidden files. It's possible this may cause problems for people in the wild because they may be unknowingly reliant on the fact that hidden files are not being deleted.

So, if we fix it, should we also change DeleteEverything policy to actually NOT delete hidden files? Then maybe include a new policy called DeleteEverythingAndHidden? I don't like this because DeleteEverything suggests it should delete everything including hidden files!

[freekmurze]

I'm going to keep this simple and threat this as a bugfix release, thanks!