Bug with typescript transformation of `Illuminate\Support\Collection` in v4.4.1 about laravel-data

[rubenvanassche]

Is a bug indeed, fixed in the next version.

[Tofandel]

Mmm, it can technically be both because the collection can have keys, if those keys are not sequential (eg 2, 7, 9), it serializes to an object which is a Record, if the Collection has no keys then it serializes to an array, so the correct type would be

export type FooData = {
collection?: Array<App.Data.SomeData> | Record<int, App.Data.SomeData>;
};
};

But I agree, if the collection is keyed with int, it's much better DX to say it should be an array because that's what it's going to be in 99.9999% cases and in the case it's not we can just say Collection<int | string, SomeData> and the type should correctly be infered as a Record

[Tofandel]

@studnitz

Did you try with

/** @var Collection<SomeData> */

[studnitz]

@studnitz

Did you try with

/** @var Collection<SomeData> */

Yes, but this results in a PHPStan error, see the last paragraph of the bug report.