Comments (4)
Is a bug indeed, fixed in the next version.
from laravel-data.
Mmm, it can technically be both because the collection can have keys, if those keys are not sequential (eg 2, 7, 9
), it serializes to an object which is a Record, if the Collection has no keys then it serializes to an array, so the correct type would be
export type FooData = {
collection?: Array<App.Data.SomeData> | Record<int, App.Data.SomeData>;
};
};
But I agree, if the collection is keyed with int, it's much better DX to say it should be an array because that's what it's going to be in 99.9999% cases and in the case it's not we can just say Collection<int | string, SomeData>
and the type should correctly be infered as a Record
from laravel-data.
Did you try with
/** @var Collection<SomeData> */
from laravel-data.
Did you try with
/** @var Collection<SomeData> */
Yes, but this results in a PHPStan error, see the last paragraph of the bug report.
from laravel-data.
Related Issues (20)
- Docs are out of date from this repo HOT 1
- Transforming to TypeScript requested a package Spatie\Enum HOT 4
- Can't include/exclude properties in collection since 4.5.0 HOT 1
- Lazy properties are not countable since v4 HOT 1
- validateAndCreate ignores rule from static rules method HOT 1
- Uncaught InvalidArgumentException: Non-backed enums have no default serialization
- Exception on validating typed fields HOT 1
- Dependencies fail to be injected into validation static override methods HOT 1
- Incorrect injection of routing parameters when using MapInputName HOT 2
- #[GreaterThan], #[GreaterThanOrEqualTo], #[LessThan], #[LessThanOrEqualTo] works not as expected (size comparision) HOT 2
- Backward compatibility is broken 4.5.1 🡒 4.6.0 HOT 1
- Array type is not cast or checked HOT 4
- Dot notation doesn't work with related model's property with MapInputName HOT 2
- Nested backed enum throwing error (must be of type Enum, string given)
- Relation with recursive reference causes infinite loop (even if it's not in the data) HOT 1
- Unable to transform data HOT 1
- Eager loaded relations are reset which throws a lazy loading violation HOT 1
- "Unique" validator with ignore parameter works wrong in sequentially run tests HOT 1
- Package does not support a `fromNull(null $null): null` handler HOT 1
- No documentation on spatie website for encrypted eloquent casting HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-data.