Comments (3)
This has todo with #432, we're going to release v3.5.1 without this feature and iron out the kinks in v4.
from laravel-data.
@rubenvanassche thanks for the update 😄 I look forward to seeing the improvements you make in v4!
from laravel-data.
So I've tried this in data v4, which is kinda ready for release and uses the validated properties. This is the test:
it('handles issue B', function (){
class ParentData extends Data
{
public function __construct(
public bool $example_bool,
public ChildData $child,
)
{
}
}
class ChildData extends Data
{
public function __construct(
public ?string $example_string = 'example',
public ?int $example_int = 123,
)
{
}
}
class DataPresentInsteadOfRequiredRuleInferrer implements RuleInferrer
{
public function handle(
DataProperty $property,
PropertyRules $rules,
ValidationContext $context,
): PropertyRules
{
if (! $property->type->kind->isDataCollectable() && ! $property->type->kind->isDataObject()) {
return $rules;
}
if (! $rules->hasType(Required::class)) {
return $rules;
}
return $rules->removeType(Required::class)
->add(new Present());
}
}
config()->set('data.rule_inferrers', [
\Spatie\LaravelData\RuleInferrers\SometimesRuleInferrer::class,
\Spatie\LaravelData\RuleInferrers\NullableRuleInferrer::class,
\Spatie\LaravelData\RuleInferrers\RequiredRuleInferrer::class,
\Spatie\LaravelData\RuleInferrers\BuiltInTypesRuleInferrer::class,
\Spatie\LaravelData\RuleInferrers\AttributesRuleInferrer::class,
DataPresentInsteadOfRequiredRuleInferrer::class,
]);
request()->merge([
'example_bool' => true,
'child' => [],
]);
$data = app(ParentData::class);
dd($data);
});
Outputting:
Spatie\LaravelData\Tests\ParentData {#3414
#_additional: []
#_dataContext: null
+example_bool: true
+child: Spatie\LaravelData\Tests\ChildData {#3497
#_additional: []
#_dataContext: null
+example_string: "example"
+example_int: 123
}
}
This looks allright to me? Could you test your use case with the beyond-data
branch? That should almost be what data v4 will be.
from laravel-data.
Related Issues (20)
- Docs are out of date from this repo HOT 1
- Transforming to TypeScript requested a package Spatie\Enum HOT 4
- Can't include/exclude properties in collection since 4.5.0 HOT 1
- Lazy properties are not countable since v4 HOT 1
- validateAndCreate ignores rule from static rules method HOT 1
- Uncaught InvalidArgumentException: Non-backed enums have no default serialization
- Exception on validating typed fields HOT 1
- Dependencies fail to be injected into validation static override methods HOT 1
- Incorrect injection of routing parameters when using MapInputName HOT 2
- #[GreaterThan], #[GreaterThanOrEqualTo], #[LessThan], #[LessThanOrEqualTo] works not as expected (size comparision) HOT 2
- Backward compatibility is broken 4.5.1 🡒 4.6.0 HOT 1
- Array type is not cast or checked HOT 4
- Dot notation doesn't work with related model's property with MapInputName HOT 2
- Nested backed enum throwing error (must be of type Enum, string given)
- Relation with recursive reference causes infinite loop (even if it's not in the data) HOT 1
- Unable to transform data HOT 1
- Eager loaded relations are reset which throws a lazy loading violation HOT 1
- "Unique" validator with ignore parameter works wrong in sequentially run tests HOT 1
- Package does not support a `fromNull(null $null): null` handler HOT 1
- No documentation on spatie website for encrypted eloquent casting HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-data.