Nested objects with empty request payloads / defaults for all properties about laravel-data

[rubenvanassche]

This has todo with #432, we're going to release v3.5.1 without this feature and iron out the kinks in v4.

[bentleyo]

@rubenvanassche thanks for the update 😄 I look forward to seeing the improvements you make in v4!

[rubenvanassche]

So I've tried this in data v4, which is kinda ready for release and uses the validated properties. This is the test:

it('handles issue B', function (){
    class ParentData extends Data
    {
        public function __construct(
            public bool $example_bool,
            public ChildData $child,
        )
        {
        }
    }

    class ChildData extends Data
    {
        public function __construct(
            public ?string $example_string = 'example',
            public ?int $example_int = 123,
        )
        {
        }
    }

    class DataPresentInsteadOfRequiredRuleInferrer implements RuleInferrer
    {
        public function handle(
            DataProperty $property,
            PropertyRules $rules,
            ValidationContext $context,
        ): PropertyRules
        {
            if (! $property->type->kind->isDataCollectable() && ! $property->type->kind->isDataObject()) {
                return $rules;
            }

            if (! $rules->hasType(Required::class)) {
                return $rules;
            }

            return $rules->removeType(Required::class)
                ->add(new Present());
        }
    }

    config()->set('data.rule_inferrers', [
        \Spatie\LaravelData\RuleInferrers\SometimesRuleInferrer::class,
        \Spatie\LaravelData\RuleInferrers\NullableRuleInferrer::class,
        \Spatie\LaravelData\RuleInferrers\RequiredRuleInferrer::class,
        \Spatie\LaravelData\RuleInferrers\BuiltInTypesRuleInferrer::class,
        \Spatie\LaravelData\RuleInferrers\AttributesRuleInferrer::class,
        DataPresentInsteadOfRequiredRuleInferrer::class,
    ]);

    request()->merge([
        'example_bool' => true,
        'child' => [],
    ]);

    $data = app(ParentData::class);

    dd($data);
});

Outputting:

Spatie\LaravelData\Tests\ParentData {#3414
  #_additional: []
  #_dataContext: null
  +example_bool: true
  +child: Spatie\LaravelData\Tests\ChildData {#3497
    #_additional: []
    #_dataContext: null
    +example_string: "example"
    +example_int: 123
  }
}

This looks allright to me? Could you test your use case with the beyond-data branch? That should almost be what data v4 will be.