Nested DataCollections very slow about laravel-data

[basbart]

Ended up making my own data object class instead of using the package

[rubenvanassche]

I DataCollection will always add an overhead, this is a massive one I agree but I don't see how we can quickly fix this. We have some benchmark tests since a few weeks, If you'll add such a case and can make performance improvements without making everything more complicated than it is already. Then I'll gladly merge the PR.

[elsuterino]

got to the same problem, in my case it adds 250-400ms to a before ~60ms response time with paginated to 10 and couple relations

[nerocil]

ed up making my own data object class instead of using the package

How did you manage to do that with typescript generate?

[basbart]

I’m assuming you’re referring to this package: https://github.com/spatie/typescript-transformer

My DTOs are just simple PHP classes with some extended logic for mapping and extracting values, the package handles converting PHP classes to typescript. You can find more information in their documentation about how to implement it with your own classes.

[nerocil]

Okay thank you.