Wallet import from Electrum misses most of the labels about sparrow

[craigraw]

Sparrow only supports importing of transaction labels from Electrum wallets at this time. I've tested again and I can't reproduce the issue on these - all transaction labels are imported.

Is there anything in sparrow.log (in your .sparrow folder) or other clues that might help?

[atom686]

Logs are empty.

[atom686]

I think the problem might be in that Sparrow imports only tx labels. In electrum it shows label for an address in TX history as well. Prob the best solution might be to import all labels available.

[craigraw]

Thanks for the feedback. Importing of address labels from Electrum added in 88dfde3.

[statusquont]

Just ran into this issue as well. I have 57 transactions in Electrum. I imported the wallet into Sparrow, and only 31 retained their labels. None of the original labels have any special characters or anything. The success/failure seems randomly distributed over time. For example, 2 of the most recent transactions, received on the same day, with nearly identical labels, one imported fine, the other didn't.

[craigraw]

Ok, I've found another reason why this might occur - Electrum sometimes takes transaction labels from address labels.

I've implemented a change in 9600d57 which copies these address labels out to transaction labels when this occurs (and the transaction label isn't present).