Collision detection with preferred aliases about elm-review-imports

[dillonkearns]

Another use case to consider:

In elm-pages I'm using this pattern which some package authors use to keep some internals accessible within the package. I have a type alias that is in an "exposed module" in the package. It has the same name as the actual internal definition.

import DataSource.Internal.Glob exposing (Glob(..))

type alias Glob a =
    DataSource.Internal.Glob.Glob a

I get this error

(fix) NoModuleOnExposedNames: Module used on exposed type `Glob`.

224| type alias Glob a =
225|     DataSource.Internal.Glob.Glob a
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It is not necessary to use the module here as `Glob` was exposed on import.

You should remove the module from this call, or remove the name from the import
.. exposing list.

However, that would result in an invalid Elm module if I followed that fix:

-- ALIAS PROBLEM - elm-pages/src/DataSource/Glob.elm

This type alias is recursive, forming an infinite type!

224| type alias Glob a =
                ^^^^
When I expand a recursive type alias, it just keeps getting bigger and bigger.
So dealiasing results in an infinitely large type! Try this instead:

    type Glob a =
        Glob
            (Glob a)

Hint: This is kind of a subtle distinction. I suggested the naive fix, but I
recommend reading <https://elm-lang.org/0.19.1/recursive-alias> for ideas on how
to do better.