Coder Social home page Coder Social logo

Comments (4)

SpacingBat3 avatar SpacingBat3 commented on July 22, 2024

I think I could try to improve it...

It serves quite important purpose: it is a confirmation that WebCord is indeed loading itself and that stuff is happening. Without that, users would just end up with the empty window, and that indicated dozens of things in the past.

I think I've previously wanted to implement it via BrowserViews so it can be displayed on top of the Discord (right now, I rely on a trick applied in Electron which displays the previous site until the next one declared that it finished to load, which is imperfect in case of Discord, due they do actually load more stuff after that happens), but those were quite buggy... They still might be in fact, although I think I found a workaround to make them render properly.

from webcord.

SpacingBat3 avatar SpacingBat3 commented on July 22, 2024

Also about this:

It adds another unnecessary delay to access the user interface.

This is only partially true, there's a small delay added only for the animation to finish (so this is more a cosmetic thing, to make things looks smoothly)... Although, this wouldn't have to be the case if I could just display the splash screen on top of the Discord page or somehow tinker with Electron so it won't display Discord page too early.

The delay it introduces shouldn't be that bad tho (around 1,5s or less if I remember correctly; I still might take some efforts to entirely eliminate it), WebCord should still load way faster than official Discord client 😛️.

from webcord.

kchousos avatar kchousos commented on July 22, 2024

WebCord should still load way faster than official Discord client

I haven't found this to be the case. Discord and Webcord load at about the same time for me, with Webcord being slower to open due to the splash.

from webcord.

SpacingBat3 avatar SpacingBat3 commented on July 22, 2024

I haven't found this to be the case. Discord and Webcord load at about the same time for me, with Webcord being slower to open due to the splash.

I'll probably should re-design the whole loading of the webpages and splash thing, since the whole code and past implementations that were kinda failure (e.g. due to many bugs in the BrowserView API) are quite outdated given Electron has now quite a number of new APIs that separates content loading to windows and allows for way greater control with that.

I still don't think WebCord loads (or should load) slower, since there's very little tasks done compared to Discord, which is even more complex and modularized to WebCord; unlike to Discord, WebCord doesn't need to wait for updates or check them for multiple components, and it also loads from a single file if you consider app.asar as such (which could reduce the FS overhead I suppose, at least from what I remember around the reasoning of packing app to it, I think that was mostly pointed out for Windows) while Discord does and implements way more stuff, including native modules.

from webcord.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.