Table shake when scroll to bottom about collectionkit

[daishuyi]

I think it is viewDidLayoutSubviews, you can make a break in the method. It is invoked when scroll to bottom, and collectionView frame will be reset. So you can set frame in viewSafeAreaInsetsDidChange, or auto layout.

The error code:
override func viewDidLayoutSubviews() {
super.viewDidLayoutSubviews()
collectionView.frame = view.bounds
}

[lkzhao]

Fixed in v1.3.1. Thanks for reporting. And sorry for the late fixes.

[lkzhao]

@tigati Please see if @humblehacker's patch #77 fix the issue for you. Checkout the latest master

pod "CollectionKit", :git => "https://github.com/SoySauceLab/CollectionKit.git"

[zhengzhou]

got the same, Especially when I use the Nib file.

[lkzhao]

Not seeing this myself, can you guys give me an example project?

[zhengzhou]

@lkzhao
simple demo
https://github.com/zhengzhou/CollectionKitDemo

[zhengzhou]

@daishuyi
that's did work. thank you very much.

[lkzhao]

@zhengzhou A temporary solution for you. Do a check before setting the frame should work.

      if collectionView.frame != view.bounds {
        collectionView.frame = view.bounds
      }

CollectionView removes or inserts a view when it goes on/offscreen. And with Auto layout, viewDidLayoutSubviews is triggered every time that happens. Apparently UIScrollView has this bug where it resets the content offset to zero when frame is assigned.

This doesn't happen with the CollectionKit example project because it doesn't use auto layout and won't trigger viewDidLayoutSubviews.

I will see what I can do to overcome this issue in the next release.

[tigati]

This fix breaks UIPageViewController default behaviour. Scrolling to last page becomes unpredictable. Also scrollview now does not bounce perfectly back. There is small gap after bouncing back.