Coder Social home page Coder Social logo

Comments (10)

ryansch avatar ryansch commented on June 26, 2024

I'm also excited to replace my existing .rvmrc parsing with the new set behavior that can rely on the project directory.

from rvm.

ryansch avatar ryansch commented on June 26, 2024

I can confirm that 'default' is now handled correctly as of rvm/rvm@8edf22c

from rvm.

ryansch avatar ryansch commented on June 26, 2024

It looks like the rvm guys are even trying to make it so you can rvm use /path/to/project-with-rvmrc. Maybe we can just kill the normalize ruby string stuff in the cookbook?

I still have issues with rvm_shell, rvm_gem if I don't specify a ruby_string. It defaults to 'default' but doesn't grab the gemset when it normalizes.

Edit: I can see from my own submission above that they've been planning to do this for 1.9. Somehow I just noticed.

from rvm.

fnichol avatar fnichol commented on June 26, 2024

I think I 70% understand what you mean. Does this still not execute properly for you (i.e. dropping the @gemset)? If you have a reference to your local patch it couldn't hurt to see.

Do you think an unset/nil rvm_string attribute value should fallback to node['rvm']['default_ruby'] instead? That might help improve Principle of Least Surprise since it could include a gemset.

Anyway, not ignoring this one, just getting my head around it :)

from rvm.

ryansch avatar ryansch commented on June 26, 2024

I've decided my patch is a bit too buggy. It introduced some weird edge cases I was hitting my head on.

I think we have 2 options:

  1. Now that rvm can resolve aliases, project directories, etc, we should change our normalization strategy to lean on what rvm is doing.
  2. Change the default for unset ruby_strings across the board to be node[:rvm][:default_ruby].

from rvm.

ryansch avatar ryansch commented on June 26, 2024

The other use case I'd really like to see is this:

rvm_wrapper 'project' do
  project_dir "/path/to/project"
  binary 'rake'
end

rvm_shell 'bundle install' do
  project_dir "/path/to/project"
  code <<-EOS
  bundle install --without test development --local
  EOS
end

With rvm_wrapper, it could still be called ruby_string. With rvm_shell I was thinking it would also set the cwd to the project dir.

Now that rvm will let you target a project directory as if it were a ruby string this shouldn't be too hard. I took a first look at how I'd implement this but was again hitting my head on what we should do about ruby_string normalization.

from rvm.

martinisoft avatar martinisoft commented on June 26, 2024

Hi @ryansch

I realize its been a while since this discussion, but would you want to submit or have already submitted a PR to include this functionality? If not then I'll close this down to clean up outstanding tickets.

from rvm.

ryansch avatar ryansch commented on June 26, 2024

@martinisoft I don't use rvm on my servers at this point. I've moved on to rbenv due to all the issues I was having. Thanks!

from rvm.

martinisoft avatar martinisoft commented on June 26, 2024

@ryansch sorry to hear that, but thank you for responding.

from rvm.

lock avatar lock commented on June 26, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from rvm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.