rvm_shell should support only_if and not_if about rvm

[fnichol]

Good idea, I work it up.

[fnichol]

I looked into this and the only_if and not_if guard attributes should work for all resources, including rvm_shell. This works:

rvm_shell 'do awesome' do
  code 'rvm list'
  only_if 'grep 42 /dev/null'
end

gives:

[Tue, 09 Aug 2011 19:37:23 +0000] INFO: Processing rvm_shell[do awesome] action run ((irb#1) line 33)
[Tue, 09 Aug 2011 19:37:23 +0000] DEBUG: Executing grep 42 /dev/null
[Tue, 09 Aug 2011 19:37:23 +0000] DEBUG: ---- Begin output of grep 42 /dev/null ----
[Tue, 09 Aug 2011 19:37:23 +0000] DEBUG: STDOUT: 
[Tue, 09 Aug 2011 19:37:23 +0000] DEBUG: STDERR: 
[Tue, 09 Aug 2011 19:37:23 +0000] DEBUG: ---- End output of grep 42 /dev/null ----
[Tue, 09 Aug 2011 19:37:23 +0000] DEBUG: Ran grep 42 /dev/null returned 1
[Tue, 09 Aug 2011 19:37:23 +0000] DEBUG: Skipping rvm_shell[do awesome] due to only_if

And in ruby block form:

rvm_shell 'i get skipped' do
  code 'rvm list'
  not_if { true != false }
end

gives:

[Tue, 09 Aug 2011 19:45:36 +0000] INFO: Processing rvm_shell[i get skipped] action run ((irb#1) line 53)
[Tue, 09 Aug 2011 19:45:36 +0000] DEBUG: Skipping rvm_shell[i get skipped] due to not_if

Am I missing something?

[jonleighton]

Hiya,

It didn't seem to work with the version I was using, but I agree it does work with the latest version of chef-rvm, so closing this.

Cheers

[fnichol]

Awesome!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.