rsyslog default configuration generated incorrectly on Amazon Linux 2 about rsyslog

[blueben]

There appears to be an incorrect assumption in the default attributes, which looks for RHEL family distros lesser than version 6 and generates a configuration for older versions of rsyslog.

# rsyslog 3/4 do not support the new :omusrmsg:* format and need * instead
if node['platform_family'] == 'rhel' && node['platform_version'].to_i < 6
  default['rsyslog']['default_facility_logs']['*.emerg'] = '*'
end

This breaks because Amazon Linux does report as being in the RHEL platform_family and platform_version 2, however provides rsyslog version 8.24.0.

[root@xxx:~]$ cat /etc/system-release
Amazon Linux release 2 (2017.12) LTS Release Candidate

[root@xxx:~]$ ohai platform platform_family platform_version
[
  "amazon"
]
[
  "rhel"
]
[
  "2"
]

[root@xxx:~]$ rpm -qi rsyslog
Name        : rsyslog
Version     : 8.24.0
Release     : 12.amzn2
Architecture: x86_64
Install Date: Wed 10 Jan 2018 02:10:56 AM UTC
Group       : System Environment/Daemons
Size        : 1982902
License     : (GPLv3+ and ASL 2.0)
Signature   : RSA/SHA256, Tue 14 Nov 2017 08:49:16 PM UTC, Key ID 11cf1f95c87f5b1a
Source RPM  : rsyslog-8.24.0-12.amzn2.src.rpm
Build Date  : Thu 19 Oct 2017 05:40:42 PM UTC
Build Host  : build.amazon.com
Relocations : (not relocatable)
Packager    : Amazon Linux
Vendor      : Amazon Linux
URL         : http://www.rsyslog.com/

The most correct solution would be to check directly for the version of rsyslog available rather than using indirect and imprecise distro checks.

[github-actions]

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

[github-actions]

Closing due to inactivity. If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.