Does not work with 2.6.0-rc6 about redisio

[cmer]

I also tried setting maxclients to something other than 0 in my json configuration file but it did not work. Installing 2.4.16 worked as expected.

"redisio": {
  "safe_install": false,
  "version": "2.4.16"
}

[brianbianco]

My guess probably has to do with specification changes to the configuration file for 2.6. I haven't toyed with deploying 2.6 with this cookbook yet but I will start work on this. It most likely will need all sorts of configuration options added for the new version jump as well.

Just as a quick hack, since the cookbook itself include the conf.d directory, you can override essentially any setting because redis honors the last found configuration setting.

I will mess with this and see what I can figure out.

[cmer]

That was fast! Thanks!

[andreacampi]

It would be nice to also support 2.2 for those stuck with it for the time being.

[brianbianco]

I will make a separate issue to get support for the 2.2 series.

[brianbianco]

It looks like between redis 2.4 -> 2.6 maxclients 0 is no longer supported. In redis 2.6 max clients will default to 10,000, and if for some reason it is unable to set max clients it will resort to max file descriptors - 32.

I think the best way to handle this situation is simply to set the maxclients default to 10000 instead of 0. This will affect users who are relying on the fact that 0 means "Until I run out of file descriptors". I suspect that a pretty supreme edge case, however it will be necessary for anybody running the 2.4 series who wants "unlimited" clients to override this attribute.

I really think this is a better alternative to injecting a bunch of unnecessary logic to determine what max clients should be by default based upon the redis version.

[brianbianco]

All that being said, I also think it is important to note that redis 2.6.0-rc6 reports it version on the command line as "2.5.12". This means that the redisio cookbook will try to compile and install redis on each run as it thinks you want 2.6.0 and have 2.5.12. My suggestion for this would be to host the redis tarball yourself somewhere and rename it from 2.6.0-rc12 to 2.5.12.

[brianbianco]

As of commit f9558e5 the redisio cookbook now works with 2.6.0-rc6. The only catch (as noted in a previous comment) is that redis reports itself as 2.5.12. If you plan on using this I highly suggest hosting the tarball yourself and changing it to be named

redis-2.5.12.tar.gz

This is because the provider checks the version reported by redis to see if it needs to install a new version. Since that is the case if you don't rename the tarball and tell it you are installing version "2.5.12" it will try to install a new version every single chef-client run (as it redis will report it is version 2.5.12 and you are telling it you want 2.6.0-rc6). While that technically isn't TOO harmful (as your current running instance is loaded into memory) it certainly is annoying and wasteful.

[brianbianco]

You could actually also set safe_install to true after installing it the first time and that should prevent it from trying to install again.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.