Package on NPM requires user's module loader to understand ES2015 modules. about ngx-sortablejs

[smnbbrv]

@wrummler thanks for the contribution! Check v2.0.6

[smnbbrv]

@wrummler ahem, that sounds weird. AOT build usually cannot break a non-AOT one, from what I know. Could you, please, tell more about your environment?

• Webpack or systemjs and the version of the one
• angular version
• angular-sortablejs version

It would also help to have a public repo where the issue could be reproduced

[rummelsworth]

I applied the README instructions to the quickstart seed and got the same error as #44. Repo here.

I don't think this is a AoT/non-AoT issue at this point. I think these issues boil down to 6b7a969 introducing the requirement that the user's module loader understand ES2015 modules. For example, my non-AoT app is a very plain Electron/Angular setup (derived from electron-forge init's Angular template) that simply uses Node's require to load modules. When it sees export, it doesn't recognize the token because Node doesn't yet provide built-in support for ES2015 modules. Similarly, when SystemJS sees it in e.g. the quickstart repo linked above, apparently it's trying to grab traceur to transpile it on-the-fly. This is part of the quickstart behavior:

Unable to load transpiler to transpile http://localhost:3000/node_modules/angular-sortablejs/dist/index.js

I made another branch that attempts to work around the issue by including configuration for systemjs-plugin-traceur. It eliminates the error in that example repo, but the behavior of the simple example included from this project's README seems incorrect, since the "See the result" items are not updated when the dragged items are.

Also, this workaround isn't available for my actual project, since we're not using SystemJS (or Webpack etc), just Node's require in Electron.

[rummelsworth]

I updated the issue title. Please consider this a suggestion to remove the requirement by including a CommonJS-compatible main entry in the distributed package.json and allowing ES2015 module users (e.g. those using AoT with Rollup) to configure their loader to point to a separate ES2015 build file also included with the distributed package. Thanks.

[smnbbrv]

that could be then the same issue as this one #44. You are right

[smnbbrv]

@wrummler could you please check if v2.0.5 fixes the issue?

[smnbbrv]

fixed the second issue too. For some reason the change detection trigger was not done

[rummelsworth]

@smnbbrv Thanks, 2.0.5 fixed it for me.

Also, I don't have an AoT setup handy to double-check, but I think that AoT/rollup users can still use this new/reverted build if they update their rollup-config.js appropriately in the object passed to the invocation of the commonjs plugin in the plugins array. (It's been a long time since I used AoT, so YMMV.)