Switch Soot API to collections API whenever necessary about soot

[patricklam]

The SPARK methods have to return Iterators for performance reasons.

On Tue, Apr 23, 2013 at 12:32 PM, Marc-André Laverdière <
[email protected]> wrote:

There is a lot of getNumXYZ and getXYZ(i) in the Soot internal API. These
methods should be marked as deprecated and the collections API should be
used instead.

Futhermore, there are many methods that return an Iterator, which cannot
be used in a for-all loop. Iterators should be wrapped in a collection
similar to Scala's IterableOnce.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/49
.

[malaverdiere]

Wrapping an iterator into an Iterable object means a negligible performance overhead. Would you please describe a use case where keeping the iterator really makes a difference?

[patricklam]

It should be OK to return an Iterable instead of an Iterator, but it would
be good to do performance tests. What's not OK is creating the backing
collection, I believe.

On Tue, Apr 23, 2013 at 12:54 PM, Marc-André Laverdière <
[email protected]> wrote:

Wrapping an iterator into an Iterable object means a negligible
performance overhead. Would you please describe a use case where keeping
the iterator really makes a difference?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/49#issuecomment-16871141
.

[malaverdiere]

I agree. That would just be an horrible overhead. It would make sense to do that only if we need to reuse the information here and there, but I have a suspicion that this is not really the case.