App breakage with unknown cover formats about plattenalbum

[SoongNoonien]

Hi!
This seems to be related to #14. In this case mpdevil tries to load the cover of some album with the readpicture/albumart command of mpd but GLib can't handle this image. Can you isolate the regarding album and send it to me, so I can work around this? But I sadly wont be able to get mpdevil displaying the cover correctly I can only ignore such images.

[dgcampea]

Can you isolate the regarding album and send it to me, so I can work around this? But I sadly wont be able to get mpdevil displaying the cover correctly I can only ignore such images.

Is there a way to enable some sort of verbose logging? I really have no idea which album is causing it as I stumbled upon this issue by pressing "all artists".

[SoongNoonien]

Is there a way to enable some sort of verbose logging?

No, not yet.

But you can go through each artists to isolate at least the artist. Isolating the album should than be relatively easy.

[SoongNoonien]

Using 'log_level "verbose"' in the mpd.conf will show all issued mpd commands. This can also be very helpful since the album will be visible in there as a parameter of the "list" command and the regarding file as parameter of the "readpicture/albumart" command.

[dgcampea]

I think I nailed it down. Blacklisting jpeg covers with JFIF standard 1.02 fixes this. (Working jpeg files are JFIF standard 1.01).

$ file "cover.jpg"
cover.jpg: JPEG image data, JFIF standard 1.02 (...)

[SoongNoonien]

This seems not to be the actual problem since I have many 1.02 files in my collection and they all work fine. Can you send me one of the covers that don't work, so I can reproduce this on my machine?

[dgcampea]

I've sent a sample to the email address in git commits.

[SoongNoonien]

Did you get my reply?

[dgcampea]

Hi, yes, sorry I couldn't get back to you sooner, I'll let you know as soon as I can

[SoongNoonien]

Ok, no problem. Take your time. I just wanted to know since your email curiously was in my spam folder.

[SoongNoonien]

The newest commit fixes the issue on my machine. Please let my know if it is working on your machine too.

[dgcampea]

I can confirm that it's working here as well (rebuilt flatpak to commit: 66bf9c3)

[SoongNoonien]

Ok, so I'll close this.

[dgcampea]

Thanks for the speedy fix!