Comments (3)
You are totally right, and your patch looks good.
I think the test_post_xxx/test_get_xxx got degraded a bit in v1.2 (had some refactoring done). It needs fixing.
I think I should just kill this raw crap and instead always return the regular response. Caller will just have to do .json() when they want it.
from box.py.
Would you like to submit a pull request? :)
from box.py.
Of cause, I'd like to. I will patch the mocked_response
and fix the broken tests.
from box.py.
Related Issues (12)
- finish_authenticate_v2 error HOT 4
- ValueError thrown when running the example from the README HOT 2
- Remove support for deprecated v1 API HOT 3
- Asynchronous requests with grequests? HOT 2
- Function for PUT request on file object HOT 1
- Allow download_file to return non-raw socket response HOT 5
- content_modified_at in upload_file HOT 4
- share_link api HOT 4
- Long Poll Error HOT 2
- Thumbnail retrieval HOT 2
- There seems to be an issue uploading files with non-ascii character in their names HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from box.py.