Comments (9)
I think we need to update the t1-lag-spine.j2
template to remove the lacp rate fast
line.
It is introduced during the deployment.
@antonpatenko could you on the VM reconfigure the interfaces to run no lacp rate fast
and check again? If that's the case, we could update the j2 template.
from sonic-mgmt.
We can't change testbed setting from lacp fast to lacp slow. We have to support LACP fast, because our T1 devices use LACP fast mode, not slow.
So, probably in our fast-reboot we need to switch from LACP fast to LACP slow on DUT and neighbors, then make fast-reboot and switch device configuration back
from sonic-mgmt.
We need a decision what to do with this issue. currently following the requirement we got on the test it is not working as expected. so we need to understand how you would like to proceed. @antonpatenko please check stcheng suggestion and update if it works then we should decide how to proceed.
from sonic-mgmt.
The LACP PDUs you receive at step 1.2 is the PDU sent by DUT, the rate should be defined by arista vm according to LACP protocol. In this case, since arista vm is configured as fast, the PDU observe rate should be fast too.
For fast reboot, we have to switch the T1 from fast to slow, and that should be T1 default value.
I think we should disable lacp fast on the arista vm.
However, since sonic DUT some times have to talk neighbor which is configured as lacp fast. In the anton's test, we need to change the neighbor lacp to fast and do a check.
from sonic-mgmt.
Looks like Shuotian's suggestion changed situation.
The packets below are captured on DUT after switching rate on VMs LAG member.
16:52:59 LACPv1, length 110
16:53:03 LACPv1, length 110
16:53:29 LACPv1, length 110
16:53:33 LACPv1, length 110
As you see, some packets are being sent faster. than slow rate requires, but in general this looks better.
from sonic-mgmt.
@antonpatenko we could for one time do an experiment to check how many packets are received during a certain long enough time and see if the lacp rate is slow. meanwhile, I think we will need a script to toggle the lacp rate on the T1 Arista devices so as to continue fast boot test.
from sonic-mgmt.
Not clear why fast boot test configuration is relevant for here.
this is T1 lag topology, maybe T0 topology and currently it does not work correct.
@stcheng you have defined the test requirements, the test is written according to the requirements but the topology or the DUT does not work as expected. We need clear definition how to proceed.
from sonic-mgmt.
@liatgrozovik Agree.
We could change t1-lag topology configuration. I'll prepare PR for sonic-mgmt. repo.
from sonic-mgmt.
Fixed by #154.
from sonic-mgmt.
Related Issues (20)
- snappi_tests: verify_tx_frame_count_dut is checking wrong numbers HOT 4
- snappi_tests: packet analysis fails due to invalid frame HOT 2
- Memory exhaustion test case fails intermittently HOT 1
- Case test_encap_with_mirror_session of test_ipinip.py failed due to swss and other dockers could not start after invoking fixture setup_mirror_session HOT 1
- [macsec] Macsec docker crashes when configuring an interface HOT 4
- [platform_tests/test_reload_config.py] FAILS due to Assertion Error HOT 1
- TACACS test_ro_user_ipv6 UT failed because IPV6 subnet unreachable.
- Reboot Tests Fail on Feb 29 during Leap Year due to bug HOT 2
- [pfcwd/test_pfc_config.py] - Case Failed to start pfcwd after load_minigraph
- config_reload.py does not handle multi-asic for running_golden_config json file loading HOT 2
- T2: iface_loopback_action/iface_loopback_action_helper.py regex to be fixed for Multiasic ports HOT 2
- [dualtor-aa] Demo issue
- [Add Topology] - Issue faced during deploying T0 topology using Wistron Boards HOT 1
- scp/test_scp_copy.py uses user name, directories as admin, instead of generic user name.. HOT 2
- Test reset_factory /test_reset_factory.py failed because of missing argument. HOT 1
- Need to install MultiPing package into sonic-mgmt container to unblock IPv6 only test
- snappi_dut_base_config takes only 3 args, but callers are having 4 args. HOT 1
- T2 system_health/test_watchdog.py require multi asic support HOT 2
- [test_route_flap] [T2] - Test fails if the selected 'dev_port' is connected to upstream T3 RegionalHub neighbor for t2-topo
- test_osbuild_version failing because unable to merge without fix HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sonic-mgmt.