Comments (8)
Hi @abdosi , @JibinBao , @stepanblyschak , for your viz. Thanks
from sonic-mgmt.
Hi @anamehra, I am looking at the test code, not sure I understand why test expects swss.service to depend on interfaces-config.service, also, why "config reload" should throw an error?
from sonic-mgmt.
Hi @stepanblyschak , the test code validates a negative scenario where config reload should fail when swss is not up yet. It relies on the timing to run the command right at the moment when redis is accessible but swss has not started yet and I think interfaces-config check was introduced just to achieve ive that. Given that swss has no dependency on interfaces-config now, the test case needs to change. I think instead of validating this negative scenario during boot, it should just explicitly stop swss and validate that config reload fails.
from sonic-mgmt.
@anamehra Thanks, so as I understand "config reload" should fail when swss is down, any reason why? "config reload" cold restarts all services, so not sure such check in "config reload" is needed or are there any issues restarting services when swss is down?
from sonic-mgmt.
@dgsudharsan, Can you help check the above issue? If there is no direct dependency between interfaces-config and swss, shoud we revert the fix #7289? And then how to stabilize the test_reload_configuration_checks?
from sonic-mgmt.
@anamehra This check was introduced to overcome a race condition where config reload gets executed while interface-services.config is running and the loopback ip is not accessible giving traceback for the command the resulting in the test failure. Below is example
Jan 4 06:29:19.434440 r-bulldog-02 INFO systemd[1]: Starting Update interfaces configuration...
Jan 4 06:29:21.659292 r-bulldog-02 INFO python[11575]: ansible-command Invoked with executable=/bin/bash _uses_shell=True _raw_params=sudo config reload -y warn=True stdin_add_newline=True strip_empty_ends=True argv=None chdir=None creates=None removes=None stdin=None
Jan 4 06:29:25.786037 r-bulldog-02 INFO systemd[1]: Finished Update interfaces configuration.
You will get
File "/usr/local/...: Unable to connect to redis: Cannot assign requested address
However this issue was fixed by @saiarcot895 sonic-net/sonic-buildimage#15080. Given we have this fix the change in sonic-mgmt can be reverted.
@JibinBao please revert the change to check interface-services.config.
from sonic-mgmt.
from sonic-mgmt.
@anamehra : Please check if below PR fixes this issue.
from sonic-mgmt.
Related Issues (20)
- test_iface_namingmode::TestConfigInterface::test_config_interface_speed HOT 1
- bgp/test_traffic_shift_sup.py harcoded for admin user, does not work for non admin sonic_admin_user HOT 3
- Traceback in 202311 branch running snappi_tests/lacp/ HOT 2
- test_pfc_mmu_change fail because of un imported argument
- testQosSaiHeadroomPoolSize and estQosSaiHeadroomPoolWatermark failed for Force10-S6100 t1-64-lag topology
- [Yang] DPU topology is using wrong dut type HOT 4
- [Vlan][Dual-Tor] The vlan ping test is failing on dualtor topology
- [test gap][dualtor-as] dualtor linked with ycable should recover from inconsistency when cable firmware is corrupted
- Add test for PFCWD storm on both Priority 3 and 4 on macsec ports HOT 2
- [IPv6 only] support IPv6 only test case for KVM testbed. HOT 2
- observed dhclient syslog errors while running sonic-mgmt tests
- What are all the modifications needed to use different NOS in Fanout switch for T0/T1 execution [other than SONiC or EOS] HOT 1
- [Autoneg] The auto negotiation test runs only on 100G ports
- snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py fails due to the difference in number of packets expected
- snappi_tests: multidut support causes failures in single-dut runs HOT 3
- T2 disk/test_disk_exhaustion.py multi-asic support HOT 3
- Snappi API does not identify port configuration for IXIA 4x100Gbps breakout links
- get_RIB_IN_capacity is called with one less argument.
- [telemetry/test_events.py] FAILS because of a timing issue
- Some test cases failure observed on sonic-buildimage master branch HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sonic-mgmt.