Coder Social home page Coder Social logo

Comments (11)

franmomu avatar franmomu commented on May 21, 2024 1

Thanks for reporting! I'll try to take a look later

from sonataintlbundle.

phansys avatar phansys commented on May 21, 2024

Please, note that "twig/intl-extra" is not an opt in replacement, since it doesn't provide the same features than this project.
By instance, the locale inference provided here through LocaleDetectorInterface is not available.
Other example pointed here #280 (comment).

from sonataintlbundle.

franmomu avatar franmomu commented on May 21, 2024

Fixed in sonata-project/SonataAdminBundle#5981

from sonataintlbundle.

core23 avatar core23 commented on May 21, 2024

This issue is not fixed at all. There is just a fix for one of our bundles. The error still occurs if you try to call format_datetime somewhere in your code.

See: sonata-project/SonataNewsBundle#591

from sonataintlbundle.

core23 avatar core23 commented on May 21, 2024

IMHO the only way to fix this issue is to check the arguments you pass to the filter and delegate this to the twig filter if necesary.

from sonataintlbundle.

core23 avatar core23 commented on May 21, 2024

This could fix the problem: #302

from sonataintlbundle.

github-actions avatar github-actions commented on May 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from sonataintlbundle.

VincentLanglet avatar VincentLanglet commented on May 21, 2024

I just encountered this bug

Twig\Extra\Intl\IntlExtension::formatDateTime(): Argument #5 ($pattern) must be of type string, null given

I'm using both SonataAdmin and SonataIntl.

Shouldn't we prefix every method here by sonata_ and deprecate the old name ?

@franmomu @phansys @core23 @jordisala1991 WDYT ?

from sonataintlbundle.

jordisala1991 avatar jordisala1991 commented on May 21, 2024

We could probably move the release of 3.0 for this bundle (it was never done) and rename those functions in the process.

from sonataintlbundle.

jordisala1991 avatar jordisala1991 commented on May 21, 2024

Because this bundle adds some value right? Or the things done here can be done with a combination of official twig extra packages?

from sonataintlbundle.

VincentLanglet avatar VincentLanglet commented on May 21, 2024

We could probably move the release of 3.0 for this bundle (it was never done) and rename those functions in the process.

Yes, this is what I had in mind with #512

from sonataintlbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.